From: Lukas Fleischer <git@cryptocrack.de>
To: Jeff King <peff@peff.net>
Cc: Lance <lancethepants@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] config: do not use C function names as struct members
Date: Tue, 27 Aug 2013 02:56:01 +0200 [thread overview]
Message-ID: <20130827005601.GA14679@blizzard> (raw)
In-Reply-To: <20130826215718.GB6219@sigill.intra.peff.net>
On Mon, Aug 26, 2013 at 05:57:18PM -0400, Jeff King wrote:
> On Mon, Aug 26, 2013 at 04:59:01PM -0400, Jeff King wrote:
>
> > Hmm. I wonder if fgetc is a macro in uclibc? Just grepping their
> > stdio.h, it looks like that is a possibility.
> >
> > I think they are probably wrong to do so (but I'd have to check the
> > standard). However, the cleaner workaround would probably be to call the
> > fgetc struct member something else.
>
> Nope, it's allowed. I think we should do the patch below:
>
> -- >8 --
> Subject: config: do not use C function names as struct members
> [...]
>
> Instead, we can simply use non-colliding names.
Yes, this sounds like a better idea to me. So, FWIW, +1 from me.
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> config.c | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> [...]
next prev parent reply other threads:[~2013-08-27 0:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 20:10 Issue with compiling git 1.8.4 under uclibc with gcc 4.6.3 Lance
2013-08-26 20:18 ` Lukas Fleischer
2013-08-26 20:29 ` Lance
2013-08-26 20:31 ` Lukas Fleischer
2013-08-26 20:59 ` Jeff King
2013-08-26 21:57 ` [PATCH] config: do not use C function names as struct members Jeff King
2013-08-27 0:56 ` Lukas Fleischer [this message]
2013-08-27 4:38 ` Junio C Hamano
2013-08-26 21:07 ` Issue with compiling git 1.8.4 under uclibc with gcc 4.6.3 Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827005601.GA14679@blizzard \
--to=git@cryptocrack.de \
--cc=git@vger.kernel.org \
--cc=lancethepants@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).