From: Jonathan Nieder <jrnieder@gmail.com>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: git@vger.kernel.org, j.sixt@viscovery.net
Subject: Re: [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of #
Date: Wed, 28 Aug 2013 16:13:26 -0700 [thread overview]
Message-ID: <20130828231326.GA4110@google.com> (raw)
In-Reply-To: <1377694024-24173-3-git-send-email-Matthieu.Moy@imag.fr>
Matthieu Moy wrote:
> Historically, "git status" needed to prefix each output line with '#' so
> that the output could be added as comment to the commit message. This
> prefix comment has no real purpose when "git status" is ran from the
> command-line, and this may distract users from the real content.
>
> Allow the user to disable this prefix comment.
Why not do this unconditionally?
> In the long run, if users
> like the non-prefix output, it may make sense to flip the default value
> to true.
Hmm, do you mean that the configuration is to give the change-averse
some time to get used to the new output? I think it would make sense
to do it all at once (and even think that that would be less
confusing).
The rest of the idea and execution seem sane.
Thanks,
Jonathan
next prev parent reply other threads:[~2013-08-28 23:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 8:32 [RFC/PATCH] status: introduce status.displayCommentChar to disable display of # Matthieu Moy
2013-08-28 11:03 ` Johannes Sixt
2013-08-28 12:43 ` Matthieu Moy
2013-08-28 12:47 ` [RFC/PATCH v2 1/3] builtin/stripspace.c: fix broken indentation Matthieu Moy
2013-08-28 12:47 ` [RFC/PATCH v2 2/3] submodule: introduce --[no-]display-comment-char Matthieu Moy
2013-08-28 21:07 ` Jens Lehmann
2013-08-29 7:04 ` Matthieu Moy
2013-08-28 12:47 ` [RFC/PATCH v2 3/3] status: introduce status.displayCommentChar to disable display of # Matthieu Moy
2013-08-28 20:05 ` Junio C Hamano
2013-08-28 20:10 ` Junio C Hamano
2013-08-28 20:18 ` Jeff King
2013-08-28 21:39 ` Junio C Hamano
2013-08-28 21:59 ` David Aguilar
2013-08-28 22:41 ` Junio C Hamano
2013-08-29 6:58 ` Matthieu Moy
2013-08-31 0:00 ` brian m. carlson
2013-08-28 20:59 ` Matthieu Moy
2013-08-28 21:53 ` Junio C Hamano
2013-08-28 21:50 ` Junio C Hamano
2013-08-28 23:13 ` Jonathan Nieder [this message]
2013-08-29 6:50 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828231326.GA4110@google.com \
--to=jrnieder@gmail.com \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).