git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: git@vger.kernel.org
Cc: gitster@pobox.com
Subject: Re: [PATCH] git send-email: include [anything]-by: signatures
Date: Sat, 31 Aug 2013 22:22:50 +0300	[thread overview]
Message-ID: <20130831192250.GA3823@redhat.com> (raw)
In-Reply-To: <20130826165747.GA30788@redhat.com>

On Mon, Aug 26, 2013 at 07:57:47PM +0300, Michael S. Tsirkin wrote:
> Consider [anything]-by: a valid signature.
> This includes Tested-by: Acked-by: Reviewed-by: etc.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Ping.
Any opinion on whether this change is acceptable?

> ---
>  git-send-email.perl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/git-send-email.perl b/git-send-email.perl
> index ecbf56f..bb9093b 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1359,7 +1359,7 @@ foreach my $t (@files) {
>  	# Now parse the message body
>  	while(<$fh>) {
>  		$message .=  $_;
> -		if (/^(Signed-off-by|Cc): (.*)$/i) {
> +		if (/^([A-Za-z-]*-by|Cc): (.*)$/i) {
>  			chomp;
>  			my ($what, $c) = ($1, $2);
>  			chomp $c;
> -- 
> MST
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2013-08-31 19:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26 16:57 [PATCH] git send-email: include [anything]-by: signatures Michael S. Tsirkin
2013-08-31 19:22 ` Michael S. Tsirkin [this message]
2013-09-03  6:35   ` Jeff King
2013-09-03  8:44     ` Michael S. Tsirkin
2013-09-03 17:06       ` Junio C Hamano
2013-09-03 21:01         ` Michael S. Tsirkin
2013-09-03 21:03           ` Jeff King
2013-09-03 21:24             ` Michael S. Tsirkin
2013-09-03 21:39             ` Junio C Hamano
2013-09-04  8:09               ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130831192250.GA3823@redhat.com \
    --to=mst@redhat.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).