From: Jonathan Nieder <jrnieder@gmail.com>
To: "Dale R. Worley" <worley@alum.mit.edu>
Cc: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
git@vger.kernel.org, gitster@pobox.com, Jeff King <peff@peff.net>
Subject: Re: the pager
Date: Mon, 2 Sep 2013 19:57:11 -0700 [thread overview]
Message-ID: <20130903025711.GA25617@elie.Belkin> (raw)
In-Reply-To: <201309030227.r832RmBd013888@freeze.ariadne.com>
Hi,
Dale R. Worley wrote:
> That's true, but it would change the effect of using "cat" as a value:
> "cat" as a value of DEFAULT_PAGER would cause git_pager() to return
> NULL, whereas now it causes git_pager() to return "cat". (All other
> places where "cat" can be a value are translated to NULL already.)
>
> This is why I want to know what the *intended* behavior is, because we
> might be changing Git's behavior, and I want to know that if we do
> that, we're changing it to what it should be. And I haven't seen
> anyone venture an opinion on what the intended behavior is.
I don't really follow.
For all practical purposes, "cat" is equivalent to no pager at all,
no? And the git-var(1) manpage describes the intended order of
precedence, as far as I can tell, except that it was written before
v1.7.4-rc0~76^2 (allow command-specific pagers in pager.<cmd>,
2010-11-17) which forgot to update some documentation.
Suggested wording for improving the documentation or its organization
would of course be welcome. And I agree with Matthieu that the name
of the pager_program global variable is needlessly confusing ---
perhaps it should be called config_pager_program or similar.
Thanks,
Jonathan
next prev parent reply other threads:[~2013-09-03 2:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 19:57 the pager Dale R. Worley
2013-08-27 4:38 ` Junio C Hamano
2013-08-28 18:19 ` Dale R. Worley
2013-08-28 20:26 ` Junio C Hamano
2013-08-29 15:41 ` Dale R. Worley
2013-08-29 15:55 ` Matthieu Moy
2013-09-03 2:27 ` Dale R. Worley
2013-09-03 2:57 ` Jonathan Nieder [this message]
2013-09-03 7:41 ` [PATCH] pager: turn on "cat" optimization for DEFAULT_PAGER Jeff King
2013-09-03 17:35 ` Junio C Hamano
2013-11-20 17:24 ` Erik Faye-Lund
2013-11-20 17:30 ` Jeff King
2013-11-20 17:33 ` Erik Faye-Lund
2013-11-20 17:33 ` Junio C Hamano
2013-11-20 17:34 ` Erik Faye-Lund
2013-09-03 8:16 ` the pager Jeff King
2013-09-03 2:37 ` Dale R. Worley
2013-09-03 8:01 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903025711.GA25617@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=worley@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).