From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH] git send-email: include [anything]-by: signatures Date: Tue, 3 Sep 2013 02:35:35 -0400 Message-ID: <20130903063535.GA3608@sigill.intra.peff.net> References: <20130826165747.GA30788@redhat.com> <20130831192250.GA3823@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: git@vger.kernel.org, gitster@pobox.com To: "Michael S. Tsirkin" X-From: git-owner@vger.kernel.org Tue Sep 03 08:35:47 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VGkDI-0004Vk-2M for gcvg-git-2@plane.gmane.org; Tue, 03 Sep 2013 08:35:44 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759473Ab3ICGfk (ORCPT ); Tue, 3 Sep 2013 02:35:40 -0400 Received: from cloud.peff.net ([50.56.180.127]:52600 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753749Ab3ICGfj (ORCPT ); Tue, 3 Sep 2013 02:35:39 -0400 Received: (qmail 18464 invoked by uid 102); 3 Sep 2013 06:35:39 -0000 Received: from c-71-63-4-13.hsd1.va.comcast.net (HELO sigill.intra.peff.net) (71.63.4.13) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.84) with ESMTPA; Tue, 03 Sep 2013 01:35:39 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Tue, 03 Sep 2013 02:35:35 -0400 Content-Disposition: inline In-Reply-To: <20130831192250.GA3823@redhat.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Sat, Aug 31, 2013 at 10:22:50PM +0300, Michael S. Tsirkin wrote: > On Mon, Aug 26, 2013 at 07:57:47PM +0300, Michael S. Tsirkin wrote: > > Consider [anything]-by: a valid signature. > > This includes Tested-by: Acked-by: Reviewed-by: etc. > > > > Signed-off-by: Michael S. Tsirkin > > Ping. > Any opinion on whether this change is acceptable? I was left confused by your commit message, as it wasn't clear to me what a "signature" is. But the point of it seems to be that people mention others in commit messages using "X-by:" pseudo-headers besides "signed-off-by", and you want to cc them along with the usual S-O-B. That seems like a reasonable goal, but I have two concerns. One, I would think the utility of this would be per-project, depending on what sorts of things people in a particular project put in pseudo-headers. Grepping the kernel history shows that most X-by headers have a person on the right-hand side, though quite often it is not a valid email address (on the other hand, quite a few s-o-b lines in the kernel do not have a valid email). And two, the existing options for enabling/disabling this code all explicitly mention signed-off-by, which becomes awkward. You did not update the documentation in your patch, but I think you would end up having to explain that "--supress-cc=sob" and "--signed-off-by-cc" really mean "all pseudo-header lines ending in -by". So I think it might be a nicer approach to introduce a new "suppress-cc" class that means "all pseudo-header tokens ending in -by" or similar. We might even want the new behavior on by default, but it would at least give the user an escape hatch if their project generates a lot of false positives. -Peff