From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH 3/4] t: rev-parse-parents: avoid yoda conditions
Date: Tue, 3 Sep 2013 17:08:55 +0200 [thread overview]
Message-ID: <20130903150855.GK29840@goldbirke> (raw)
In-Reply-To: <CAMP44s349-v6xtCvbDzycVj1wBwTdAgLmuGxB0pYn6CmHYkM1Q@mail.gmail.com>
On Tue, Sep 03, 2013 at 08:39:54AM -0500, Felipe Contreras wrote:
> On Tue, Sep 3, 2013 at 6:10 AM, SZEDER Gábor <szeder@ira.uka.de> wrote:
> > On Tue, Sep 03, 2013 at 05:45:06AM -0500, Felipe Contreras wrote:
> >> On Tue, Sep 3, 2013 at 3:03 AM, Jeff King <peff@peff.net> wrote:
> >> > On Tue, Sep 03, 2013 at 09:51:07AM +0200, SZEDER Gábor wrote:
> >> >
> >> >> > I wonder if we should have a:
> >> >> >
> >> >> > test_cmp_args () {
> >> >> > echo "$1" >expect &&
> >> >> > echo "$1" >actual &&
> >> >> > test_cmp expect actual
> >> >> > }
> >> >> >
> >> >> > to let these remain one-liners like:
> >> >> >
> >> >> > test_cmp_args "$(git rev-parse start)" "$(git rev-parse final^1^1^1)"
BTW, why not just use the already existing
test_cmp_rev start final^1^1^1
helper function to get usable output on error and still keep these as
one-liners?
> >> >> This idea come up before, but there is one flaw which makes this
> >> >> function less useful: a non-zero exit code of the commands in the
> >> >> command substitutions would be lost.
> >> >
> >> > Good point. You'd probably have to do something gross with eval, like:
> >> >
> >> > test_cmp_args () {
> >> > eval "$1" >expect &&
> >> > eval "$2" >actual &&
> >>
> >> I don't see any reason to perpetuate these yoda comparisons.
> >>
> >> eval "$2" >expect &&
> >> eval "$1" >actual &&
> >
> > I do. Your proposal requires the arguments in the reverse order
> > compared to test_cmp. That inconsistency would be far worse than
> > test_cmp_args "$expect" "$actual".
>
> There are two ways to fix an inconsistency, the other way is to fix
> test_cmp. But that would be a change, and change is not welcome in
> Git.
It depends on the change, I suppose. I agree, changing 3k+ lines just
to avoid yoda conditions... I doubt the gain worth the code churn.
Best,
Gábor
next prev parent reply other threads:[~2013-09-03 15:09 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 6:30 [PATCH 0/4] t: rev-parse-parents: cleanups Felipe Contreras
2013-09-02 6:30 ` [PATCH 1/4] t: rev-parse-parents: fix style Felipe Contreras
2013-09-02 6:30 ` [PATCH 2/4] t: rev-parse-parents: fix weird ! notation Felipe Contreras
2013-09-02 6:30 ` [PATCH 3/4] t: rev-parse-parents: avoid yoda conditions Felipe Contreras
2013-09-03 7:12 ` Jeff King
2013-09-03 7:51 ` SZEDER Gábor
2013-09-03 8:03 ` Jeff King
2013-09-03 10:45 ` Felipe Contreras
2013-09-03 11:10 ` SZEDER Gábor
2013-09-03 13:39 ` Felipe Contreras
2013-09-03 15:08 ` SZEDER Gábor [this message]
2013-09-03 17:04 ` [PATCH 0/4] " Jonathan Nieder
2013-09-03 17:05 ` [PATCH 1/4] rev-parse test: modernize quoting and whitespace Jonathan Nieder
2013-09-03 17:06 ` [PATCH 2/4] rev-parse test: use test_must_fail, not "if <command>; then false; fi" Jonathan Nieder
2013-09-03 21:56 ` Felipe Contreras
2013-09-03 17:07 ` [PATCH 3/4] rev-parse test: use test_cmp instead of "test" builtin Jonathan Nieder
2013-09-03 20:01 ` Junio C Hamano
2013-09-04 4:28 ` Jonathan Nieder
2013-09-03 22:01 ` Felipe Contreras
2013-09-03 17:11 ` [PATCH 4/4] rev-parse test: use standard test functions for setup Jonathan Nieder
2013-09-03 17:15 ` [PATCH v2 " Jonathan Nieder
2013-09-03 17:20 ` [PATCH 0/4] Re: [PATCH 3/4] t: rev-parse-parents: avoid yoda conditions Jeff King
2013-09-03 21:53 ` Felipe Contreras
2013-09-04 16:47 ` Junio C Hamano
2013-09-04 17:13 ` John Keeping
2013-09-04 17:38 ` Junio C Hamano
2013-09-04 18:36 ` Jeff King
2013-09-04 19:14 ` Junio C Hamano
2013-09-08 3:11 ` Felipe Contreras
2013-09-08 4:06 ` Jeff King
2013-09-08 4:13 ` Felipe Contreras
2013-09-08 4:14 ` Felipe Contreras
2013-09-08 4:26 ` Jeff King
2013-09-08 4:52 ` Felipe Contreras
2013-09-08 5:02 ` Jeff King
2013-09-08 23:25 ` Felipe Contreras
2013-09-08 23:45 ` Jeff King
2013-09-09 0:45 ` Felipe Contreras
2013-09-08 18:33 ` Junio C Hamano
2013-09-08 23:18 ` Felipe Contreras
2013-09-08 8:11 ` Philip Oakley
2013-09-03 17:31 ` Junio C Hamano
2013-09-03 17:33 ` Junio C Hamano
2013-09-03 21:52 ` Felipe Contreras
2013-09-02 6:30 ` [PATCH 4/4] t: rev-parse-parents: simplify setup Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903150855.GK29840@goldbirke \
--to=szeder@ira.uka.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).