git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
	Jeff King <peff@peff.net>,
	git@vger.kernel.org
Subject: [PATCH v2 4/4] rev-parse test: use standard test functions for setup
Date: Tue, 3 Sep 2013 10:15:46 -0700	[thread overview]
Message-ID: <20130903171546.GF29921@google.com> (raw)
In-Reply-To: <20130903171137.GE29921@google.com>

From: Felipe Contreras <felipe.contreras@gmail.com>

Save the reader from learning specialized t6* setup functions
where familiar commands like test_commit, "git checkout --orphan",
and "git merge" will do.

While at it, wrap the setup commands in a test assertion so errors can
be caught and stray output suppressed when running without --verbose
as in other tests.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
Lost a line from the patch last time (removal of the
'. "$TEST_DIRECTORY"/lib-t6000.sh' directive.  Sorry about that ---
fixed now.

 t/t6101-rev-parse-parents.sh | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/t/t6101-rev-parse-parents.sh b/t/t6101-rev-parse-parents.sh
index 8a6ff66..7ea14ce 100755
--- a/t/t6101-rev-parse-parents.sh
+++ b/t/t6101-rev-parse-parents.sh
@@ -6,7 +6,6 @@
 test_description='Test git rev-parse with different parent options'
 
 . ./test-lib.sh
-. "$TEST_DIRECTORY"/lib-t6000.sh # t6xxx specific functions
 
 test_cmp_rev_output () {
 	git rev-parse --verify "$1" >expect &&
@@ -14,14 +13,15 @@ test_cmp_rev_output () {
 	test_cmp expect actual
 }
 
-date >path0
-git update-index --add path0
-save_tag tree git write-tree
-hide_error save_tag start unique_commit "start" tree
-save_tag second unique_commit "second" tree -p start
-hide_error save_tag start2 unique_commit "start2" tree
-save_tag two_parents unique_commit "next" tree -p second -p start2
-save_tag final unique_commit "final" tree -p two_parents
+test_expect_success 'setup' '
+	test_commit start &&
+	test_commit second &&
+	git checkout --orphan tmp &&
+	test_commit start2 &&
+	git checkout master &&
+	git merge -m next start2 &&
+	test_commit final
+'
 
 test_expect_success 'start is valid' '
 	git rev-parse start | grep "^[0-9a-f]\{40\}$"
-- 
1.8.4

  reply	other threads:[~2013-09-03 17:15 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-02  6:30 [PATCH 0/4] t: rev-parse-parents: cleanups Felipe Contreras
2013-09-02  6:30 ` [PATCH 1/4] t: rev-parse-parents: fix style Felipe Contreras
2013-09-02  6:30 ` [PATCH 2/4] t: rev-parse-parents: fix weird ! notation Felipe Contreras
2013-09-02  6:30 ` [PATCH 3/4] t: rev-parse-parents: avoid yoda conditions Felipe Contreras
2013-09-03  7:12   ` Jeff King
2013-09-03  7:51     ` SZEDER Gábor
2013-09-03  8:03       ` Jeff King
2013-09-03 10:45         ` Felipe Contreras
2013-09-03 11:10           ` SZEDER Gábor
2013-09-03 13:39             ` Felipe Contreras
2013-09-03 15:08               ` SZEDER Gábor
2013-09-03 17:04                 ` [PATCH 0/4] " Jonathan Nieder
2013-09-03 17:05                   ` [PATCH 1/4] rev-parse test: modernize quoting and whitespace Jonathan Nieder
2013-09-03 17:06                   ` [PATCH 2/4] rev-parse test: use test_must_fail, not "if <command>; then false; fi" Jonathan Nieder
2013-09-03 21:56                     ` Felipe Contreras
2013-09-03 17:07                   ` [PATCH 3/4] rev-parse test: use test_cmp instead of "test" builtin Jonathan Nieder
2013-09-03 20:01                     ` Junio C Hamano
2013-09-04  4:28                       ` Jonathan Nieder
2013-09-03 22:01                     ` Felipe Contreras
2013-09-03 17:11                   ` [PATCH 4/4] rev-parse test: use standard test functions for setup Jonathan Nieder
2013-09-03 17:15                     ` Jonathan Nieder [this message]
2013-09-03 17:20                   ` [PATCH 0/4] Re: [PATCH 3/4] t: rev-parse-parents: avoid yoda conditions Jeff King
2013-09-03 21:53                   ` Felipe Contreras
2013-09-04 16:47                   ` Junio C Hamano
2013-09-04 17:13                     ` John Keeping
2013-09-04 17:38                       ` Junio C Hamano
2013-09-04 18:36                         ` Jeff King
2013-09-04 19:14                           ` Junio C Hamano
2013-09-08  3:11                           ` Felipe Contreras
2013-09-08  4:06                             ` Jeff King
2013-09-08  4:13                               ` Felipe Contreras
2013-09-08  4:14                                 ` Felipe Contreras
2013-09-08  4:26                                 ` Jeff King
2013-09-08  4:52                                   ` Felipe Contreras
2013-09-08  5:02                                     ` Jeff King
2013-09-08 23:25                                       ` Felipe Contreras
2013-09-08 23:45                                         ` Jeff King
2013-09-09  0:45                                           ` Felipe Contreras
2013-09-08 18:33                                   ` Junio C Hamano
2013-09-08 23:18                                     ` Felipe Contreras
2013-09-08  8:11                               ` Philip Oakley
2013-09-03 17:31               ` Junio C Hamano
2013-09-03 17:33                 ` Junio C Hamano
2013-09-03 21:52                 ` Felipe Contreras
2013-09-02  6:30 ` [PATCH 4/4] t: rev-parse-parents: simplify setup Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130903171546.GF29921@google.com \
    --to=jrnieder@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).