From: Jeff King <peff@peff.net>
To: Richard Hansen <rhansen@bbn.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v3] peel_onion(): add support for <rev>^{tag}
Date: Tue, 3 Sep 2013 13:46:04 -0400 [thread overview]
Message-ID: <20130903174604.GD1050@sigill.intra.peff.net> (raw)
In-Reply-To: <1378229853-21236-1-git-send-email-rhansen@bbn.com>
On Tue, Sep 03, 2013 at 01:37:33PM -0400, Richard Hansen wrote:
> ---
> Changes since v2 (2013-09-02, see
> <http://thread.gmane.org/gmane.comp.version-control.git/233598>):
> * add a test case (hopefully I didn't go overboard)
Personally I was thinking just
test_must_fail git rev-parse HEAD^{tag} &&
git rev-parse commit-tag >expect &&
git rev-parse commit-tag^{tag} >actual &&
test_cmp expect actual
but I do not think it hurts to be more thorough.
Thanks, this version of the patch looks ready to me.
-Peff
next prev parent reply other threads:[~2013-09-03 17:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 17:37 [PATCH v3] peel_onion(): add support for <rev>^{tag} Richard Hansen
2013-09-03 17:46 ` Jeff King [this message]
2013-09-03 19:03 ` Eric Sunshine
2013-09-03 19:39 ` Richard Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130903174604.GD1050@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rhansen@bbn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).