From: Heiko Voigt <hvoigt@hvoigt.net>
To: Joergen Edelbo <jed@napatech.com>
Cc: git@vger.kernel.org, spearce@spearce.org,
Pat Thoyts <patthoyts@gmail.com>
Subject: Re: [PATCH] git-gui: Modify push dialog to support Gerrit review
Date: Thu, 5 Sep 2013 08:20:45 +0200 [thread overview]
Message-ID: <20130905062045.GA4197@sandbox-ub> (raw)
In-Reply-To: <20130904150853.52EC4121B7E@jed-dev-01.labnet>
Hi,
On Mon, Sep 02, 2013 at 10:54:19AM +0200, Joergen Edelbo wrote:
> Problem: It is not possible to push for Gerrit review
> as you will always try to push to /refs/heads/... on
> the remote. As you should not be forced to work on a
> branch with the same name as some branch on the remote,
> some more flexibility in the selection of destination
> branch is also needed.
>
> Changes done:
>
> Remove selection of branches to push - push always HEAD.
> This can be justified by the fact that this far the most
> common thing to do.
> Specify both the remote repository to push to as well as
> the specific branch on that remote. This gives the flexibility.
>
> Add option to specify "Gerrit review". If selected, replace
> the traditional "heads" with the artificial "for" in the
> destination ref spec. This is what actually solved the trigger
> problem.
>
> Limit the branches to select from to the known branches
> for currently selected remote. This is motivated in better
> usability. Works only when "usettk" is true - it is left for
> further study how to change the values in tk_optionMenu on the
> fly.
>
> Signed-off-by: Joergen Edelbo <jed@napatech.com>
> ---
> Hi there,
>
> We are at Napatech A/S just about to roll out a Git/Gerrit/Jenkins
> solution. It will really help the gui oriented people in pushing
> commits if this can be done directly in git-gui.
I like where this is heading. I myself was thinking about this some time
ago. Lets include Pat in the CC, since he is the current maintainer of
git-gui.
Give me some time to review/testdrive the patch.
Cheers Heiko
next prev parent reply other threads:[~2013-09-05 6:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 8:54 [PATCH] git-gui: Modify push dialog to support Gerrit review Joergen Edelbo
2013-09-05 6:20 ` Heiko Voigt [this message]
2013-09-05 6:42 ` Johannes Sixt
2013-09-05 8:29 ` Jørgen Edelbo
2013-09-05 8:57 ` Johannes Sixt
2013-09-05 9:18 ` Jørgen Edelbo
2013-09-05 9:31 ` Johannes Sixt
2013-09-05 17:34 ` Junio C Hamano
2013-09-06 8:17 ` Jørgen Edelbo
2013-09-05 21:04 ` Heiko Voigt
2013-09-05 18:19 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2013-09-06 10:30 Joergen Edelbo
2013-09-06 21:49 ` Phil Hord
2013-09-07 17:03 ` Jørgen Edelbo
2013-09-12 9:21 Joergen Edelbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905062045.GA4197@sandbox-ub \
--to=hvoigt@hvoigt.net \
--cc=git@vger.kernel.org \
--cc=jed@napatech.com \
--cc=patthoyts@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).