From: Jeff King <peff@peff.net>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH v4 0/5] Disable "git status" comment prefix
Date: Fri, 6 Sep 2013 17:55:10 -0400 [thread overview]
Message-ID: <20130906215509.GA13319@sigill.intra.peff.net> (raw)
In-Reply-To: <vpq38phsvuc.fsf@anie.imag.fr>
On Fri, Sep 06, 2013 at 07:28:43PM +0200, Matthieu Moy wrote:
> >> FWIW, I had the same thought as Junio. I much prefer something like
> >> status.displayCommentPrefix for clarity and future-proofing.
> >
> > Sounds fine, but I don't understand why we'd want this to be an option
> > with a future in the first place. Why not just fix the remaining bugs
> > before merging to master and make it unconditional?
>
> I think some old-time users may appreciate to have a
> backward-compatibility option. It doesn't cost much for us, as we need
> the variable internally (to use the prefix in COMMIT_EDITMSG, and not on
> stdout), and it actually makes it easier to test.
Exactly. I kind of prefer the old output, though it is probably just
having my brain rotted from seeing it so much. I'm going to give the new
behavior a try for a while to see if I adjust, but ultimately I'd like
to have the escape hatch. And as you say, it doesn't cost much, since we
have to keep both code paths anyway.
> I won't change the header part in this topic (no time, sorry), but the
> missing newline before "nothing added" actually sounds like a bug, as
> there is normally a newline after each list of file in `git status`,
> except untracked and ignored.
>
> I'll fix it as a separate patch in the next round.
Thanks for looking into it.
-Peff
prev parent reply other threads:[~2013-09-06 21:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 9:50 [PATCH v4 0/5] Disable "git status" comment prefix Matthieu Moy
2013-09-05 9:50 ` [PATCH v4 1/5] builtin/stripspace.c: fix broken indentation Matthieu Moy
2013-09-05 9:50 ` [PATCH v4 2/5] wt-status: use argv_array API Matthieu Moy
2013-09-05 9:50 ` [PATCH v4 3/5] submodule summary: ignore --for-status option Matthieu Moy
2013-09-05 9:50 ` [PATCH v4 4/5] status: disable display of '#' comment prefix by default Matthieu Moy
2013-09-05 9:50 ` [PATCH v4 5/5] tests: don't set status.oldStyle file-wide Matthieu Moy
2013-09-05 12:35 ` [PATCH v4 0/5] Disable "git status" comment prefix Matthieu Moy
2013-09-05 19:13 ` Junio C Hamano
2013-09-05 19:36 ` Matthieu Moy
2013-09-05 23:09 ` Junio C Hamano
2013-09-05 23:23 ` Jeff King
2013-09-06 16:44 ` Matthieu Moy
2013-09-06 16:53 ` Jonathan Nieder
2013-09-06 17:28 ` Matthieu Moy
2013-09-06 18:12 ` Junio C Hamano
2013-09-06 18:43 ` Matthieu Moy
2013-09-06 21:55 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130906215509.GA13319@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).