From: Jeff King <peff@peff.net>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, mhagger@alum.mit.edu, jkoleszar@google.com,
gitster@pobox.com, jrnieder@gmail.com
Subject: Re: [PATCH v2] http-backend: provide Allow header for 405
Date: Thu, 12 Sep 2013 00:46:37 -0400 [thread overview]
Message-ID: <20130912044637.GA1356@sigill.intra.peff.net> (raw)
In-Reply-To: <1378945801-122021-1-git-send-email-sandals@crustytoothpaste.net>
On Thu, Sep 12, 2013 at 12:30:01AM +0000, brian m. carlson wrote:
> The HTTP 1.1 standard requires an Allow header for 405 Method Not Allowed:
>
> The response MUST include an Allow header containing a list of valid methods
> for the requested resource.
>
> So provide such a header when we return a 405 to the user agent.
>
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
Thanks, this looks good to me.
-Peff
prev parent reply other threads:[~2013-09-12 4:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 0:30 [PATCH v2] http-backend: provide Allow header for 405 brian m. carlson
2013-09-12 0:33 ` Jonathan Nieder
2013-09-12 4:46 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912044637.GA1356@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jkoleszar@google.com \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).