git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Keeping <john@keeping.me.uk>
To: Sebastian Schuberth <sschuberth@gmail.com>
Cc: Jeff King <peff@peff.net>, Jonathan Nieder <jrnieder@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Karsten Blees <karsten.blees@gmail.com>
Subject: Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined
Date: Thu, 12 Sep 2013 11:14:19 +0100	[thread overview]
Message-ID: <20130912101419.GY2582@serenity.lan> (raw)
In-Reply-To: <CAHGBnuP3iX9pqm5kK9_WjAXr5moDuJ1jxtUkXwKEt2jjLTcLkQ@mail.gmail.com>

On Thu, Sep 12, 2013 at 11:36:56AM +0200, Sebastian Schuberth wrote:
> > Just wondering if that is the root of the problem, or if maybe there is
> > something else subtle going on. Also, does __CRT_INLINE just turn into
> > "inline", or is there perhaps some other pre-processor magic going on?
> 
> This is the function definition from string.h after preprocessing:
> 
> extern __inline__ int __attribute__((__cdecl__)) __attribute__ ((__nothrow__))
> strncasecmp (const char * __sz1, const char * __sz2, size_t __sizeMaxCompare)
>   {return _strnicmp (__sz1, __sz2, __sizeMaxCompare);}

I wonder if GCC has changed it's behaviour to more closely match C99.
Clang as a compatibility article about this sort of issue:

    http://clang.llvm.org/compatibility.html#inline

  reply	other threads:[~2013-09-12 10:14 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-11 16:06 [PATCH] git-compat-util: Avoid strcasecmp() being inlined Sebastian Schuberth
2013-09-11 18:29 ` Jonathan Nieder
2013-09-11 19:16   ` Jeff King
2013-09-19  6:04     ` Piotr Krukowiecki
     [not found]       ` <CAPc5daVt4Q9twub5KyOQqZHx9CwOnkuwA97sXV44fF2j1e5HVg@mail.gmail.com>
2013-09-19  9:47         ` Piotr Krukowiecki
2013-09-19 21:16           ` Jeff King
2013-09-19 22:03             ` Junio C Hamano
2013-09-19 22:05               ` Jeff King
2013-09-19 22:40                 ` Junio C Hamano
2013-09-20  3:18                   ` Jeff King
2013-09-20  6:21             ` Piotr Krukowiecki
2013-09-24  5:32               ` Jeff King
2013-09-11 19:59   ` Sebastian Schuberth
2013-09-11 21:41     ` Jeff King
2013-09-12  9:36       ` Sebastian Schuberth
2013-09-12 10:14         ` John Keeping [this message]
2013-09-12 15:37           ` Junio C Hamano
2013-09-12 18:20             ` Jeff King
2013-09-12 18:35               ` Junio C Hamano
2013-09-12 18:38                 ` Jonathan Nieder
2013-09-12 19:51                   ` Sebastian Schuberth
2013-09-12 20:08                     ` Junio C Hamano
2013-09-13 12:33                       ` Sebastian Schuberth
2013-09-13 14:26                         ` Junio C Hamano
2013-09-13 19:34                           ` Sebastian Schuberth
2013-09-12 21:36                     ` Jonathan Nieder
2013-09-12 19:00                 ` Jeff King
2013-09-12 19:46               ` Sebastian Schuberth
2013-09-12 20:22                 ` Jeff King
2013-09-12 20:29                   ` Junio C Hamano
2013-09-13 12:47                     ` Sebastian Schuberth
2013-09-13 14:37                       ` Junio C Hamano
2013-09-13 19:53                         ` Sebastian Schuberth
2013-09-13 19:56                           ` Linus Torvalds
2013-09-13 20:03                             ` Sebastian Schuberth
2013-09-13 20:01                           ` Junio C Hamano
2013-09-13 20:04                             ` Sebastian Schuberth
2013-09-13 22:06                               ` Junio C Hamano
2013-09-13 22:35                                 ` Junio C Hamano
2013-09-15 12:44                                 ` Sebastian Schuberth
2013-09-17 16:17                                   ` Junio C Hamano
2013-09-17 19:16                                     ` Sebastian Schuberth
2013-09-17 21:46                                       ` Junio C Hamano
2013-09-18  9:43                                         ` Sebastian Schuberth
2013-09-18 12:19                                           ` Linus Torvalds
2013-09-12 21:31                 ` Jonathan Nieder
2013-09-19 13:47                   ` Sebastian Schuberth
2013-09-11 18:39 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130912101419.GY2582@serenity.lan \
    --to=john@keeping.me.uk \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=karsten.blees@gmail.com \
    --cc=peff@peff.net \
    --cc=sschuberth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).