From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, John Keeping <john@keeping.me.uk>,
Sebastian Schuberth <sschuberth@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Karsten Blees <karsten.blees@gmail.com>
Subject: Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined
Date: Thu, 12 Sep 2013 11:38:49 -0700 [thread overview]
Message-ID: <20130912183849.GI4326@google.com> (raw)
In-Reply-To: <xmqqd2odq45y.fsf@gitster.dls.corp.google.com>
Junio C Hamano wrote:
> I think we would want something like below.
Looks good to me, but
> -- >8 --
> Subject: [PATCH] mailmap: work around implementations with pure inline strcasecmp
>
> On some systems, string.h has _only_ inline definition of strcasecmp
Please specify which system we are talking about: s/some systems/MinGW 4.0/
[...]
> --- a/mailmap.c
> +++ b/mailmap.c
> @@ -52,6 +52,19 @@ static void free_mailmap_entry(void *p, const char *s)
> string_list_clear_func(&me->namemap, free_mailmap_info);
> }
>
> +/*
> + * On some systems, string.h has _only_ inline definition of strcasecmp
Likewise.
With or without that change,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
next prev parent reply other threads:[~2013-09-12 18:38 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 16:06 [PATCH] git-compat-util: Avoid strcasecmp() being inlined Sebastian Schuberth
2013-09-11 18:29 ` Jonathan Nieder
2013-09-11 19:16 ` Jeff King
2013-09-19 6:04 ` Piotr Krukowiecki
[not found] ` <CAPc5daVt4Q9twub5KyOQqZHx9CwOnkuwA97sXV44fF2j1e5HVg@mail.gmail.com>
2013-09-19 9:47 ` Piotr Krukowiecki
2013-09-19 21:16 ` Jeff King
2013-09-19 22:03 ` Junio C Hamano
2013-09-19 22:05 ` Jeff King
2013-09-19 22:40 ` Junio C Hamano
2013-09-20 3:18 ` Jeff King
2013-09-20 6:21 ` Piotr Krukowiecki
2013-09-24 5:32 ` Jeff King
2013-09-11 19:59 ` Sebastian Schuberth
2013-09-11 21:41 ` Jeff King
2013-09-12 9:36 ` Sebastian Schuberth
2013-09-12 10:14 ` John Keeping
2013-09-12 15:37 ` Junio C Hamano
2013-09-12 18:20 ` Jeff King
2013-09-12 18:35 ` Junio C Hamano
2013-09-12 18:38 ` Jonathan Nieder [this message]
2013-09-12 19:51 ` Sebastian Schuberth
2013-09-12 20:08 ` Junio C Hamano
2013-09-13 12:33 ` Sebastian Schuberth
2013-09-13 14:26 ` Junio C Hamano
2013-09-13 19:34 ` Sebastian Schuberth
2013-09-12 21:36 ` Jonathan Nieder
2013-09-12 19:00 ` Jeff King
2013-09-12 19:46 ` Sebastian Schuberth
2013-09-12 20:22 ` Jeff King
2013-09-12 20:29 ` Junio C Hamano
2013-09-13 12:47 ` Sebastian Schuberth
2013-09-13 14:37 ` Junio C Hamano
2013-09-13 19:53 ` Sebastian Schuberth
2013-09-13 19:56 ` Linus Torvalds
2013-09-13 20:03 ` Sebastian Schuberth
2013-09-13 20:01 ` Junio C Hamano
2013-09-13 20:04 ` Sebastian Schuberth
2013-09-13 22:06 ` Junio C Hamano
2013-09-13 22:35 ` Junio C Hamano
2013-09-15 12:44 ` Sebastian Schuberth
2013-09-17 16:17 ` Junio C Hamano
2013-09-17 19:16 ` Sebastian Schuberth
2013-09-17 21:46 ` Junio C Hamano
2013-09-18 9:43 ` Sebastian Schuberth
2013-09-18 12:19 ` Linus Torvalds
2013-09-12 21:31 ` Jonathan Nieder
2013-09-19 13:47 ` Sebastian Schuberth
2013-09-11 18:39 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912183849.GI4326@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=karsten.blees@gmail.com \
--cc=peff@peff.net \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).