Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined

[Jeff King <peff@peff.net>]

On Thu, Sep 12, 2013 at 11:35:21AM -0700, Junio C Hamano wrote:

> >>  - change it to a "statis inline";
> >>  - remove "inline" from the definition;
> >>  - provide an external (non-inline) def somewhere else;
> >>  - compile with gnu899 dialect.
> >
> > Right, option 3 seems perfectly reasonable to me, as we must be prepared
> > to cope with a decision not to inline the function, and there has to be
> > _some_ linked implementation. But shouldn't libc be providing an
> > external, linkable strcasecmp in this case?
> 
> That is exactly my point when I said that the third one is nonsense
> for a definition in the standard header file.

Yes, but I am saying it is the responsibility of libc. IOW, I am
wondering if this particular mingw environment is simply broken, and if
so, what is the status on the fix?  Could another option be to declare
the environment unworkable and tell people to upgrade?

I am not even sure if we are right to call it broken, but talking to the
mingw people might be a good next step, as they will surely have an
opinion. :)

-Peff