From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff King Subject: Re: [PATCH] git-compat-util: Avoid strcasecmp() being inlined Date: Thu, 12 Sep 2013 15:00:19 -0400 Message-ID: <20130912190019.GB636@sigill.intra.peff.net> References: <523094F0.9000509@gmail.com> <20130911182921.GE4326@google.com> <20130911214116.GA12235@sigill.intra.peff.net> <20130912101419.GY2582@serenity.lan> <20130912182057.GB32069@sigill.intra.peff.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: John Keeping , Sebastian Schuberth , Jonathan Nieder , Git Mailing List , Karsten Blees To: Junio C Hamano X-From: git-owner@vger.kernel.org Thu Sep 12 21:00:28 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VKC7w-0006nQ-7R for gcvg-git-2@plane.gmane.org; Thu, 12 Sep 2013 21:00:28 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755242Ab3ILTAY (ORCPT ); Thu, 12 Sep 2013 15:00:24 -0400 Received: from cloud.peff.net ([50.56.180.127]:57175 "EHLO peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753359Ab3ILTAX (ORCPT ); Thu, 12 Sep 2013 15:00:23 -0400 Received: (qmail 4416 invoked by uid 102); 12 Sep 2013 19:00:23 -0000 Received: from c-71-63-4-13.hsd1.va.comcast.net (HELO sigill.intra.peff.net) (71.63.4.13) (smtp-auth username relayok, mechanism cram-md5) by peff.net (qpsmtpd/0.84) with ESMTPA; Thu, 12 Sep 2013 14:00:23 -0500 Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Thu, 12 Sep 2013 15:00:19 -0400 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Thu, Sep 12, 2013 at 11:35:21AM -0700, Junio C Hamano wrote: > >> - change it to a "statis inline"; > >> - remove "inline" from the definition; > >> - provide an external (non-inline) def somewhere else; > >> - compile with gnu899 dialect. > > > > Right, option 3 seems perfectly reasonable to me, as we must be prepared > > to cope with a decision not to inline the function, and there has to be > > _some_ linked implementation. But shouldn't libc be providing an > > external, linkable strcasecmp in this case? > > That is exactly my point when I said that the third one is nonsense > for a definition in the standard header file. Yes, but I am saying it is the responsibility of libc. IOW, I am wondering if this particular mingw environment is simply broken, and if so, what is the status on the fix? Could another option be to declare the environment unworkable and tell people to upgrade? I am not even sure if we are right to call it broken, but talking to the mingw people might be a good next step, as they will surely have an opinion. :) -Peff