git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "Kyle J. McKay" <mackyle@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Thomas Rast <trast@inf.ethz.ch>, Jeff King <peff@peff.net>,
	git@vger.kernel.org
Subject: Re: [PATCH v2] urlmatch.c: recompute ptr after append_normalized_escapes
Date: Thu, 12 Sep 2013 15:05:05 -0700	[thread overview]
Message-ID: <20130912220505.GM4326@google.com> (raw)
In-Reply-To: <85CEBFAA-8905-46EC-88C5-5DDE629B73F9@gmail.com>

Kyle J. McKay wrote:

> The longer comment looks good to me.  If you think the code will be safe from
> simplification patches without a comment, that works for me too.

I think if we can't trust reviewers to catch this kind of thing, we're
in trouble (i.e., moving too fast). :)

So FWIW my instinct is to leave the comment out, since I actually find
it more readable that way (otherwise I would wonder, "Why am I being
told that a strbuf's buffer has a nonconstant address?  Do some other
strbufs have a constant address or something?")

Thanks,
Jonathan

  reply	other threads:[~2013-09-12 22:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-12  9:57 [PATCH] urlmatch: append_normalized_escapes can reallocate norm.buf Thomas Rast
2013-09-12 14:15 ` [PATCH v2] urlmatch.c: recompute ptr after append_normalized_escapes Kyle J. McKay
2013-09-12 15:25   ` Thomas Rast
2013-09-12 18:23     ` Junio C Hamano
2013-09-12 18:30   ` Junio C Hamano
2013-09-12 20:38     ` Kyle J. McKay
2013-09-12 22:05       ` Jonathan Nieder [this message]
2013-09-12 22:26         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130912220505.GM4326@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mackyle@gmail.com \
    --cc=peff@peff.net \
    --cc=trast@inf.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).