From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: Git rebase dies with fatal: Unable to create '.../.git/index.lock': File exists.
Date: Mon, 16 Sep 2013 15:21:59 -0600 [thread overview]
Message-ID: <20130916212159.GA16437@obsidianresearch.com> (raw)
In-Reply-To: <20130916211501.GA5477@sigill.intra.peff.net>
On Mon, Sep 16, 2013 at 05:15:01PM -0400, Jeff King wrote:
> On Mon, Sep 16, 2013 at 12:28:52PM -0600, Jason Gunthorpe wrote:
>
> > I have emacs windows open that have files within the git tree open in
> > them. My emacs has vc-git mode loaded and global-auto-revert-mode set.
> >
> > During the rebase the files open in emacs are changed by git, when
> > emacs notices this (which is random with respect to the ongoing
> > rebase) it auto reverts and runs git commands (due to vc-git), which
> > causes the rebase to randomly fail.
> >
> > Worse, I've noticed that this also randomly seems to cause the rebase
> > to loose a commit if you --continue from that point.
> >
> > Can git have some retry in the locking so this doesn't happen?
>
> I'm not clear on which git commands are being run. If they are actually
> mutating the index, then isn't this more than a lock contention issue?
> In other words, "git rebase" is assuming nobody is mucking with the
> index while it runs; if emacs is doing so, then the results could be
> quite confusing, even if we retried the lock acquisition.
I'm not sure what commands vc-git mode in Emacs is actually running
automatically, but I'd be surprised and alaramed if they were mutating
command..
I agree retry on the lock is hackish, holding the lock continuously
rather than release/reaquire during operation would be much stronger
prevention.
Jason
next prev parent reply other threads:[~2013-09-16 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 18:28 Git rebase dies with fatal: Unable to create '.../.git/index.lock': File exists Jason Gunthorpe
2013-09-16 21:15 ` Jeff King
2013-09-16 21:21 ` Jason Gunthorpe [this message]
2013-09-16 21:47 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916212159.GA16437@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).