From: Jeff King <peff@peff.net>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: git@vger.kernel.org
Subject: Re: Git rebase dies with fatal: Unable to create '.../.git/index.lock': File exists.
Date: Mon, 16 Sep 2013 17:47:20 -0400 [thread overview]
Message-ID: <20130916214720.GA6195@sigill.intra.peff.net> (raw)
In-Reply-To: <20130916212159.GA16437@obsidianresearch.com>
On Mon, Sep 16, 2013 at 03:21:59PM -0600, Jason Gunthorpe wrote:
> > I'm not clear on which git commands are being run. If they are actually
> > mutating the index, then isn't this more than a lock contention issue?
> > In other words, "git rebase" is assuming nobody is mucking with the
> > index while it runs; if emacs is doing so, then the results could be
> > quite confusing, even if we retried the lock acquisition.
>
> I'm not sure what commands vc-git mode in Emacs is actually running
> automatically, but I'd be surprised and alaramed if they were mutating
> command..
>
> I agree retry on the lock is hackish, holding the lock continuously
> rather than release/reaquire during operation would be much stronger
> prevention.
If it is not mutating the index in a way that marks content to be
committed, but only "refreshing" it (i.e., updating the stat cache),
that should be OK. So the question there would be: what refresh strategy
does emacs use? Does it do so intentionally, or is it doing so
accidentally by calling a porcelain command that auto-refreshes? So
again, it comes down to figuring out exactly which commands emacs is
running.
-Peff
prev parent reply other threads:[~2013-09-16 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 18:28 Git rebase dies with fatal: Unable to create '.../.git/index.lock': File exists Jason Gunthorpe
2013-09-16 21:15 ` Jeff King
2013-09-16 21:21 ` Jason Gunthorpe
2013-09-16 21:47 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916214720.GA6195@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jgunthorpe@obsidianresearch.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).