From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Kevin Bracey <kevin@bracey.fi>,
Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org
Subject: Re: breakage in revision traversal with pathspec
Date: Wed, 25 Sep 2013 05:12:59 -0400 [thread overview]
Message-ID: <20130925091259.GA5844@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqeh8jqt38.fsf@gitster.dls.corp.google.com>
On Fri, Sep 20, 2013 at 10:51:55AM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > My original question was going to be: why bother peeling at all if we
> > are just going to push the outer objects, anyway?
> >
> > And after staring at it, I somehow convinced myself that the answer was
> > that you were pushing both. But that is not the case. Sorry for the
> > noise.
>
> But that is still a valid point, and the patch to avoid peeling for
> non symmetric diff does not look too bad, either.
>
> revision.c | 59 ++++++++++++++++++++++++++++++------------------
> t/t6000-rev-list-misc.sh | 8 +++++++
> 2 files changed, 45 insertions(+), 22 deletions(-)
FWIW, the flow of this version makes more sense to me. It also allows
things like:
git rev-list --objects $blob..$tree
which I cannot see anybody actually wanting, but it somehow seems
simpler to me to say "A..B" is syntactic sugar for "^B A", without
qualifying "except that A and B must be commit-ishes".
-Peff
prev parent reply other threads:[~2013-09-25 9:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 17:19 breakage in revision traversal with pathspec Junio C Hamano
2013-09-10 21:27 ` Kevin Bracey
2013-09-10 22:23 ` Junio C Hamano
2013-09-11 17:49 ` Kevin Bracey
2013-09-11 18:24 ` Jonathan Nieder
2013-09-11 19:21 ` Junio C Hamano
2013-09-11 19:39 ` Kevin Bracey
2013-09-11 21:15 ` Junio C Hamano
2013-09-19 21:35 ` Junio C Hamano
2013-09-20 3:35 ` Jeff King
2013-09-20 4:58 ` Junio C Hamano
2013-09-20 5:11 ` Jeff King
2013-09-20 17:51 ` Junio C Hamano
2013-09-25 9:12 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925091259.GA5844@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=kevin@bracey.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).