From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: "Kyle J. McKay" <mackyle@gmail.com>
Subject: [PATCH 5/9] http: provide effective url to callers
Date: Sat, 28 Sep 2013 04:32:02 -0400 [thread overview]
Message-ID: <20130928083202.GE2131@sigill.intra.peff.net> (raw)
In-Reply-To: <20130928082956.GA22610@sigill.intra.peff.net>
When we ask curl to access a URL, it may follow one or more
redirects to reach the final location. We have no idea
this has happened, as curl takes care of the details and
simply returns the final content to us.
The final URL that we ended up with can be accessed via
CURLINFO_EFFECTIVE_URL. Let's make that optionally available
to callers of http_get_*, so that they can make further
decisions based on the redirection.
Signed-off-by: Jeff King <peff@peff.net>
---
http.c | 4 ++++
http.h | 6 ++++++
2 files changed, 10 insertions(+)
diff --git a/http.c b/http.c
index 5504b2c..65a0048 100644
--- a/http.c
+++ b/http.c
@@ -911,6 +911,10 @@ static int http_request(const char *url,
curlinfo_strbuf(slot->curl, CURLINFO_CONTENT_TYPE,
options->content_type);
+ if (options && options->effective_url)
+ curlinfo_strbuf(slot->curl, CURLINFO_EFFECTIVE_URL,
+ options->effective_url);
+
curl_slist_free_all(headers);
strbuf_release(&buf);
diff --git a/http.h b/http.h
index 17116ab..974ede7 100644
--- a/http.h
+++ b/http.h
@@ -133,6 +133,12 @@ struct http_get_options {
/* If non-NULL, returns the content-type of the response. */
struct strbuf *content_type;
+
+ /*
+ * If non-NULL, returns the URL we ended up at, including any
+ * redirects we followed.
+ */
+ struct strbuf *effective_url;
};
/* Return values for http_get_*() */
--
1.8.4.rc3.19.g9da5bf6
next prev parent reply other threads:[~2013-09-28 8:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-28 8:29 [PATCH 0/9] following http redirects Jeff King
2013-09-28 8:31 ` [PATCH 1/9] http_get_file: style fixes Jeff King
2013-09-28 8:31 ` [PATCH 2/9] http_request: factor out curlinfo_strbuf Jeff King
2013-09-28 8:31 ` [PATCH 3/9] http: refactor options to http_get_* Jeff King
2013-09-28 8:31 ` [PATCH 4/9] http: hoist credential request out of handle_curl_result Jeff King
2013-09-28 8:32 ` Jeff King [this message]
2013-09-28 8:34 ` [PATCH 6/9] http: update base URLs when we see redirects Jeff King
2013-09-29 18:54 ` brian m. carlson
2013-09-29 19:26 ` Eric Sunshine
2013-09-29 19:32 ` Jeff King
2013-09-29 19:50 ` Eric Sunshine
2013-10-18 18:25 ` Junio C Hamano
2013-10-18 18:42 ` Jeff King
2013-10-18 19:20 ` Junio C Hamano
2013-09-28 8:35 ` [PATCH 7/9] remote-curl: make refs_url a strbuf Jeff King
2013-09-28 8:35 ` [PATCH 8/9] remote-curl: store url as " Jeff King
2013-09-28 8:35 ` [PATCH 9/9] remote-curl: rewrite base url from info/refs redirects Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130928083202.GE2131@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=mackyle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).