From: Jonathan Nieder <jrnieder@gmail.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: "Carlos Martín Nieto" <cmn@elego.de>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] send-pack: don't send a thin pack when the server doesn't support it
Date: Tue, 8 Oct 2013 15:22:15 -0700 [thread overview]
Message-ID: <20131008222215.GI9464@google.com> (raw)
In-Reply-To: <CACsJy8AHAbDuz3yhsjJfRQUGg1zzx6qqoAf=1oNhbX1xPVithg@mail.gmail.com>
Duy Nguyen wrote:
> Or maybe it's not that late. How about you go with your patch and add
> thin-pack capability to receive-pack too?
>
> When new "git push" is used against old server, thin pack is disabled.
> But that's not a big deal (I hope).
Could we have separate patches to introduce the server-side capability
and then to request it in the client? That way, people with old
servers can apply the patch introducing the capability if they want.
The new meaning of the "thin-pack" capability should also be
documented in Documentation/technical/protocol-capabilities.txt.
Done that way and with enough time between the server advertising the
capability and the client looking for it, it seems like a good idea.
My two cents,
Jonathan
next prev parent reply other threads:[~2013-10-08 22:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 8:44 [PATCH] send-pack: don't send a thin pack when the server doesn't support it Carlos Martín Nieto
2013-10-08 9:44 ` Duy Nguyen
2013-10-08 10:58 ` Carlos Martin Nieto
2013-10-08 11:29 ` Duy Nguyen
2013-10-08 22:22 ` Jonathan Nieder [this message]
2013-10-19 15:19 ` Carlos Martín Nieto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131008222215.GI9464@google.com \
--to=jrnieder@gmail.com \
--cc=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).