git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Make "git status" show if on tag
       [not found] <6d645eb.6b85c8d7.52559ec7.8a3b0@o2.pl>
@ 2013-10-09 18:54 ` bpuzon
  2013-10-09 19:01   ` Jeff King
  2013-10-09 19:03   ` Jonathan Nieder
  0 siblings, 2 replies; 3+ messages in thread
From: bpuzon @ 2013-10-09 18:54 UTC (permalink / raw)
  To: git

Hello Git,
 
I was wondering if a patch that adds the tag information (something like what "git log --decorate" produces) to the "git status" would be welcome?
 
All the best,
Bartek

--
本日も小田急線をご利用いただきまして、どうもありがとうございました。

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Make "git status" show if on tag
  2013-10-09 18:54 ` Make "git status" show if on tag bpuzon
@ 2013-10-09 19:01   ` Jeff King
  2013-10-09 19:03   ` Jonathan Nieder
  1 sibling, 0 replies; 3+ messages in thread
From: Jeff King @ 2013-10-09 19:01 UTC (permalink / raw)
  To: bpuzon; +Cc: git

On Wed, Oct 09, 2013 at 08:54:25PM +0200, bpuzon wrote:

> I was wondering if a patch that adds the tag information (something
> like what "git log --decorate" produces) to the "git status" would be
> welcome?

Do you mean when you are on a branch that also happens to point at the
same commit found at a tag? Or do you mean when you have detached your
HEAD at a tag (e.g., by doing "git checkout v1.0").

In the latter case, git v1.8.3 and later will print the tag name
already.

If the former, I don't have a strong opinion (it is not something I
would find useful, but I can see how others might). If it were not
intrusive, like:

  # On branch master (v1.0)

I don't think anybody would complain. It does involve enumerating all of
the refs to calculate it, which might be noticeable. OTOH, "status" is
not exactly a lightweight operation already, since it has to refresh the
whole index.

You might also consider just showing "git describe" output, which will
show a tag if you are on it, but also show your distance to the nearest
tag otherwise.  It is more expensive to calculate, though.

-Peff

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Make "git status" show if on tag
  2013-10-09 18:54 ` Make "git status" show if on tag bpuzon
  2013-10-09 19:01   ` Jeff King
@ 2013-10-09 19:03   ` Jonathan Nieder
  1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Nieder @ 2013-10-09 19:03 UTC (permalink / raw)
  To: bpuzon; +Cc: git

Hi Bartek,

bpuzon wrote:

> I was wondering if a patch that adds the tag information (something
> like what "git log --decorate" produces) to the "git status" would
> be welcome?

It would slow down "git status" a little.  I haven't thought carefully
about whether that cost is worth it --- it's hard to know without a
rough patch to try it out. ;-)

So the patch would be welcome, as a way to find out.

Thanks,
Jonathan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-10-09 19:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <6d645eb.6b85c8d7.52559ec7.8a3b0@o2.pl>
2013-10-09 18:54 ` Make "git status" show if on tag bpuzon
2013-10-09 19:01   ` Jeff King
2013-10-09 19:03   ` Jonathan Nieder

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).