From: Jeff King <peff@peff.net>
To: Eric Wong <normalperson@yhbt.net>
Cc: Daniel Stenberg <daniel@haxx.se>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] http: use curl's tcp keepalive if available
Date: Tue, 15 Oct 2013 01:00:28 -0400 [thread overview]
Message-ID: <20131015050028.GA8150@sigill.intra.peff.net> (raw)
In-Reply-To: <20131015045814.GA12312@dcvr.yhbt.net>
On Tue, Oct 15, 2013 at 04:58:14AM +0000, Eric Wong wrote:
> > Subject: http: use curl's tcp keepalive if available
> [...]
> Tested-by: Eric Wong <normalperson@yhbt.net>
> on curl 7.21.0 and 7.26.0, confirmed via strace:
>
> setsockopt(fd, SOL_SOCKET, SO_KEEPALIVE, [1], 4) = 0
>
> I can also confirm 7.26.0 adds:
>
> setsockopt(fd, SOL_TCP, TCP_KEEPIDLE, [60], 4) = 0
> setsockopt(fd, SOL_TCP, TCP_KEEPINTVL, [60], 4) = 0
>
> to the strace on Linux.
Thanks, I didn't actually do any testing myself.
> Case 2 works fine on my Debian Squeeze system.
>
> > Now we have an extra option:
> >
> > c. Tell them to upgrade curl. :)
>
> Yes, I keep forgetting I still have a Debian Squeeze machine :x
I am more concerned with Windows, which may not compile your original
patch at all.
-Peff
next prev parent reply other threads:[~2013-10-15 5:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-12 22:29 [PATCH] http: enable keepalive on TCP sockets Eric Wong
2013-10-13 9:44 ` Daniel Stenberg
2013-10-14 5:27 ` Eric Wong
2013-10-14 21:40 ` Jeff King
2013-10-14 23:38 ` Eric Wong
2013-10-15 0:06 ` [PATCH] http: use curl's tcp keepalive if available Jeff King
2013-10-15 4:58 ` Eric Wong
2013-10-15 5:00 ` Jeff King [this message]
2013-10-15 6:03 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015050028.GA8150@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=daniel@haxx.se \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).