From: Jonathan Nieder <jrnieder@gmail.com>
To: Nicolas Vigier <boklm@mars-attacks.org>
Cc: git@vger.kernel.org, Pierre Habouzit <madcoder@debian.org>
Subject: Re: [PATCH] rev-parse --parseopt: fix handling of optional arguments
Date: Tue, 15 Oct 2013 16:14:27 -0700 [thread overview]
Message-ID: <20131015231427.GF9464@google.com> (raw)
In-Reply-To: <1381838425-18244-1-git-send-email-boklm@mars-attacks.org>
Nicolas Vigier wrote:
> $ cat /tmp/opt.sh
> #!/bin/sh
> OPTIONS_SPEC="\
> git [options]
> --
> q,quiet be quiet
> S,gpg-sign? GPG-sign commit"
> echo "$OPTIONS_SPEC" | git rev-parse --parseopt $parseopt_extra -- "$@"
>
> Then the following two commands give us the same result :
>
> $ /tmp/opt.sh -S -q
> set -- -S -q --
> $ /tmp/opt.sh -S-q
> set -- -S '-q' --
>
> We cannot know if '-q' is an argument to '-S' or a new option.
Hmph.
As Junio mentioned, inserting '' would be a backward-incompatible
change. I don't think it's worth breaking existing scripts. Probably
what is needed is a new parseopt special character with the new
semantics (e.g.,
Use ?? to mean the option has an optional argument. If the
option is supplied without its argument, the argument is taken
to be ''.
or something like
Use ?<default> to mean the option has an optional argument. If
the option is supplied without its argument and <default> is
nonempty, the argument is taken to be <default>.
).
Sensible?
Thanks,
Jonathan
next prev parent reply other threads:[~2013-10-15 23:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 12:00 [PATCH] rev-parse --parseopt: fix handling of optional arguments Nicolas Vigier
2013-10-15 22:55 ` Junio C Hamano
2013-10-15 23:47 ` Nicolas Vigier
2013-10-15 23:14 ` Jonathan Nieder [this message]
2013-10-15 23:33 ` Junio C Hamano
2013-10-15 23:57 ` Jonathan Nieder
2013-10-16 7:04 ` Johannes Sixt
2013-10-16 8:53 ` Jeff King
2013-10-16 21:40 ` Junio C Hamano
2013-10-16 21:50 ` Jeff King
2013-10-16 10:58 ` Nicolas Vigier
2013-10-16 14:14 ` Nicolas Vigier
2013-10-16 22:33 ` Jonathan Nieder
2013-10-25 20:18 ` [PATCH] rev-parse --parseopt: add the --sticked-long mode Nicolas Vigier
2013-10-25 22:01 ` Junio C Hamano
2013-10-25 22:52 ` Nicolas Vigier
2013-10-25 22:55 ` Junio C Hamano
2013-10-26 21:55 ` Philip Oakley
2013-10-28 15:47 ` Junio C Hamano
2013-10-31 11:08 ` sticked -> stuck Nicolas Vigier
2013-10-31 11:08 ` [PATCH 1/2] Use the word 'stuck' instead of 'sticked' Nicolas Vigier
2013-10-31 19:35 ` Junio C Hamano
2013-10-31 11:08 ` [PATCH 2/2] rev-parse --parseopt: add the --stuck-long mode Nicolas Vigier
2013-10-27 5:45 ` [PATCH] rev-parse --parseopt: add the --sticked-long mode Michael Haggerty
2013-10-15 23:53 ` [PATCH] rev-parse --parseopt: fix handling of optional arguments Nicolas Vigier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131015231427.GF9464@google.com \
--to=jrnieder@gmail.com \
--cc=boklm@mars-attacks.org \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).