From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Fick Subject: Re: RFE: support change-id generation natively Date: Mon, 21 Oct 2013 12:49:49 -0600 Organization: CAF Message-ID: <201310211249.49568.mfick@codeaurora.org> References: <2127507934.9293293.1382367063640.JavaMail.root@openwide.fr> <201310212029.01589.thomas@koch.ro> <1382380858.25852.36711509.53CF173C@webmail.messagingengine.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: Thomas Koch , Jeremy Rosen , git@vger.kernel.org, Shawn Pearce To: james.moger@gitblit.com X-From: git-owner@vger.kernel.org Mon Oct 21 20:49:57 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VYKY8-00069x-Mn for gcvg-git-2@plane.gmane.org; Mon, 21 Oct 2013 20:49:57 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751809Ab3JUStx (ORCPT ); Mon, 21 Oct 2013 14:49:53 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:44525 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803Ab3JUStw (ORCPT ); Mon, 21 Oct 2013 14:49:52 -0400 Received: from smtp.codeaurora.org (localhost [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 1B95113EE01; Mon, 21 Oct 2013 18:49:52 +0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 486) id 0DCF713EFFA; Mon, 21 Oct 2013 18:49:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-caf-smtp.dmz.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.3.1 Received: from mfick-lnx.localnet (mfick-lnx.qualcomm.com [129.46.10.58]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: mfick@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8915213EE01; Mon, 21 Oct 2013 18:49:51 +0000 (UTC) User-Agent: KMail/1.13.5 (Linux/2.6.32.49+drm33.21-mfick7; KDE/4.4.5; x86_64; ; ) In-Reply-To: <1382380858.25852.36711509.53CF173C@webmail.messagingengine.com> X-Virus-Scanned: ClamAV using ClamSMTP Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Monday, October 21, 2013 12:40:58 pm james.moger@gitblit.com wrote: > On Mon, Oct 21, 2013, at 02:29 PM, Thomas Koch wrote: > > As I understand, a UUID could also be used for the same > > purbose as the change- > > id. How is the change-id generated by the way? Would it > > be a good english name > > to call it enduring commit identifier? > > Here is the algorithm: > https://git.eclipse.org/c/jgit/jgit.git/tree/org.eclipse. > jgit/src/org/eclipse/jgit/util/ChangeIdUtil.java#n78 > > I think "enduring commit id" is a fair interpretation of > it's purpose. I don't speak for the Gerrit developers so > I can not say if they are interested in alternative id > generation. I come to the list as a change-id > user/consumer. As a Gerrit maintainer, I would suspect that we would welcome a way to track "changes" natively in git. Despite any compatibility issues with the current Gerrit implementation, I suspect we would be open to new forms if the git community has a better proposal than the current Change-Id. Especially if it does reduce the significant user pain point of installing a hook! -Martin -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation