git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ondřej Bílka" <neleai@seznam.cz>
To: Shawn Pearce <spearce@spearce.org>
Cc: james.moger@gitblit.com, Jeremy Rosen <jeremy.rosen@openwide.fr>,
	git <git@vger.kernel.org>
Subject: Re: RFE: support change-id generation natively
Date: Mon, 21 Oct 2013 18:38:12 +0200	[thread overview]
Message-ID: <20131021163812.GA27125@domone.podge> (raw)
In-Reply-To: <CAJo=hJtbciJ3Qg8jo4U5fZ9onf2R2XOospYKGS-jCYz4p-nwRw@mail.gmail.com>

On Mon, Oct 21, 2013 at 09:35:07AM -0700, Shawn Pearce wrote:
> On Mon, Oct 21, 2013 at 8:41 AM,  <james.moger@gitblit.com> wrote:
> > The change-id is exactly like a commit-id, it is an SHA-1 value, but it
> > is a constant embedded in the commit message.
> 
> https://gerrit-review.googlesource.com/Documentation/user-changeid.html
> goes into more detail about these.
> 
> > Commit-ids change all the time because of amend; change-ids are constant
> > and they are the key that links commit revisions to a discussion.
> 
> In a mailing list based workflow, when an author revises a patch
> series and resends the new patches aren't linked to the old patches in
> a MUA, because the Message-Ids of the original versions were not
> preserved. Imagine if Git saved that original Message-Id somewhere and
> could properly write In-Reply-To headers so that attempt #2 for each
> patch replies to the end of the thread discussing attempt #1 of the
> same patch. In a 30 patch series. Gerrit does this with Change-Id.
> 
> 
> We briefly considered putting the Change-Id into the commit headers
> (e.g. below the optional encoding) but could not because `git commit`
> doesn't support this. So it went into the footer along with
> Signed-off-by provenance data, which is also not expressible in
> headers.

What about adding that as Note?

  reply	other threads:[~2013-10-21 16:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-21 14:48 RFE: support change-id generation natively james.moger
2013-10-21 14:51 ` Jeremy Rosen
2013-10-21 15:41   ` james.moger
2013-10-21 16:35     ` Shawn Pearce
2013-10-21 16:38       ` Ondřej Bílka [this message]
2013-10-21 23:07         ` Shawn Pearce
2013-10-21 18:29     ` Thomas Koch
2013-10-21 18:40       ` james.moger
2013-10-21 18:49         ` Martin Fick
2013-10-22 19:50           ` Junio C Hamano
2013-10-22 20:06             ` Pyeron, Jason J CTR (US)
2013-10-22 20:43               ` Junio C Hamano
2013-10-23  6:36             ` Duy Nguyen
2013-10-23 16:00               ` Junio C Hamano
2013-10-24  2:07                 ` Duy Nguyen
2013-10-24  4:11                   ` Nasser Grainawi
2013-10-24  5:25                     ` Duy Nguyen
2013-10-24  6:01                       ` Johannes Sixt
2013-10-24 12:11                         ` james.moger
2013-10-24 12:51                           ` Thomas Koch
2013-10-24 13:31                           ` Duy Nguyen
2013-10-24 20:04                         ` Junio C Hamano
2013-10-25  6:37                           ` Johannes Sixt
2013-10-21 23:10         ` Shawn Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131021163812.GA27125@domone.podge \
    --to=neleai@seznam.cz \
    --cc=git@vger.kernel.org \
    --cc=james.moger@gitblit.com \
    --cc=jeremy.rosen@openwide.fr \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).