From: Jeff King <peff@peff.net>
To: Brian Gernhardt <brian@gernhardtsoftware.com>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] t5570: Update for clone-progress-to-stderr branch
Date: Mon, 21 Oct 2013 14:41:54 -0400 [thread overview]
Message-ID: <20131021184154.GA29681@sigill.intra.peff.net> (raw)
In-Reply-To: <1382378052-89929-2-git-send-email-brian@gernhardtsoftware.com>
On Mon, Oct 21, 2013 at 01:54:12PM -0400, Brian Gernhardt wrote:
> git clone now reports its progress to standard error, which throws off
> t5570. Using test_i18ngrep instead of test_cmp allows the test to be
> more flexible by only looking for the expected error and ignoring any
> other output from the program.
Thanks, this is due to my 68b939b. I dealt with the fallout elsewhere in
the test suite, but I did not run with GIT_TEST_GIT_DAEMON set (and I do
not think Junio does, either). I'll start doing so.
I already have GIT_TEST_HTTPD set, and after a quick grep I don't think
I am missing any others (I do skip the svn, cvs, and p4 tests, though,
as I do not have them installed).
-Peff
prev parent reply other threads:[~2013-10-21 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-21 17:54 [PATCH 1/2] t5570: Update for symref capability Brian Gernhardt
2013-10-21 17:54 ` [PATCH 2/2] t5570: Update for clone-progress-to-stderr branch Brian Gernhardt
2013-10-21 18:41 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131021184154.GA29681@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).