From: Simon Ruderich <simon@ruderich.org>
To: git@vger.kernel.org
Cc: Jeff King <peff@peff.net>
Subject: Git v1.8.4.2 test failure in ./t5570-git-daemon.sh
Date: Tue, 29 Oct 2013 01:54:31 +0100 [thread overview]
Message-ID: <20131029005430.GA23920@ruderich.org> (raw)
Hello,
I just compiled Git v1.8.4.2 on Debian Wheezy amd64 and test
t5570 fails (with GIT_TEST_GIT_DAEMON=1):
--- expect 2013-10-28 23:27:26.792409631 +0000
+++ output 2013-10-28 23:27:26.788409614 +0000
@@ -1 +1,2 @@
+Cloning into 'nowhere'...
fatal: remote error: access denied or repository not exported: /nowhere.git
[18908] [19625] Disconnected (with error)
not ok 9 - clone non-existent
--- expect 2013-10-28 23:27:26.944410377 +0000
+++ output 2013-10-28 23:27:26.944410377 +0000
@@ -1 +1,2 @@
+Cloning into 'nowhere'...
fatal: remote error: no such repository: /nowhere.git
[19727] [19747] Disconnected (with error)
not ok 13 - clone non-existent
Bisecting leads to this commit:
commit 68b939b2f097b6675c4aaa178655559aa81b25cb
Author: Jeff King <peff@peff.net>
Date: Wed Sep 18 16:05:13 2013 -0400
clone: send diagnostic messages to stderr
Putting messages like "Cloning into.." and "done" on stdout
is un-Unix and uselessly clutters the stdout channel. Send
them to stderr.
We have to tweak two tests to accommodate this:
1. t5601 checks for doubled output due to forking, and
doesn't actually care where the output goes; adjust it
to check stderr.
2. t5702 is trying to test whether progress output was
sent to stderr, but naively does so by checking
whether stderr produced any output. Instead, have it
look for "%", a token found in progress output but not
elsewhere (and which lets us avoid hard-coding the
progress text in the test).
This should not regress any scripts that try to parse the
current output, as the output is already internationalized
and therefore unstable.
Regards
Simon
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
next reply other threads:[~2013-10-29 0:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 0:54 Simon Ruderich [this message]
2013-10-29 1:30 ` Git v1.8.4.2 test failure in ./t5570-git-daemon.sh Jeff King
2013-10-30 1:12 ` Junio C Hamano
2013-10-30 7:00 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029005430.GA23920@ruderich.org \
--to=simon@ruderich.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).