From: Jeff King <peff@peff.net>
To: Simon Ruderich <simon@ruderich.org>
Cc: Junio C Hamano <gitster@pobox.com>,
Brian Gernhardt <brian@gernhardtsoftware.com>,
git@vger.kernel.org
Subject: Re: Git v1.8.4.2 test failure in ./t5570-git-daemon.sh
Date: Mon, 28 Oct 2013 21:30:24 -0400 [thread overview]
Message-ID: <20131029013024.GA11861@sigill.intra.peff.net> (raw)
In-Reply-To: <20131029005430.GA23920@ruderich.org>
On Tue, Oct 29, 2013 at 01:54:31AM +0100, Simon Ruderich wrote:
> I just compiled Git v1.8.4.2 on Debian Wheezy amd64 and test
> t5570 fails (with GIT_TEST_GIT_DAEMON=1):
> [...]
> Bisecting leads to this commit:
>
> commit 68b939b2f097b6675c4aaa178655559aa81b25cb
> Author: Jeff King <peff@peff.net>
> Date: Wed Sep 18 16:05:13 2013 -0400
>
> clone: send diagnostic messages to stderr
This is already fixed by Brian Gernhardt's 360a326 (t5570: Update for
clone-progress-to-stderr branch, 2013-10-21).
Junio, that patch seems to have gone onto jc/upload-pack-send-symref,
but should have gone onto jk/clone-progress-to-stderr. The latter made
it into maint for v1.8.4.2, but the former did not.
I think it was just a simple mixup caused by Brian sending two fixups to
t5570 as series, when they are really fixups for two different topics.
Not worth an immediate v1.8.4.3, I think, but you may want to
cherry-pick 360a326 onto maint if there is another release before
v1.8.5.
-Peff
next prev parent reply other threads:[~2013-10-29 1:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 0:54 Git v1.8.4.2 test failure in ./t5570-git-daemon.sh Simon Ruderich
2013-10-29 1:30 ` Jeff King [this message]
2013-10-30 1:12 ` Junio C Hamano
2013-10-30 7:00 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029013024.GA11861@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=simon@ruderich.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).