git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Re* [BUG?] "error: cache entry has null sha1"
Date: Sun, 3 Nov 2013 03:03:00 -0500	[thread overview]
Message-ID: <20131103080300.GA2868@sigill.intra.peff.net> (raw)
In-Reply-To: <1383345895-23341-1-git-send-email-gitster@pobox.com>

On Fri, Nov 01, 2013 at 03:44:52PM -0700, Junio C Hamano wrote:

> Here is a proposed endgame for the topic in a patch form, then.
> 
> I've added a test for low-level "read-tree --reset -u A B", and
> tried the "am --abort" I saw the problem with manually, but other
> than that, I haven't (re)thought about the issue hard enough to be
> comfortable with this change yet.

Thanks for moving this forward.

I read over the old discussion and the patches, and I think the patch is
a good thing. There was some question from me earlier on whether there
were other cases we weren't considering.  The discussion convinced me
that there almost certainly aren't. And even if there are, this is still
the right direction. Writing out a bogus CE_CONFLICTED entry is
_certainly_ wrong, so even if we do not get the details right (e.g.,
rejecting a merge we should be accepting), this patch still forms a base
for further fixups.

> Jeff King (1):
>   unpack-trees: fix "read-tree -u --reset A B" with conflicted index

My missing signoff:

  Signed-off-by: Jeff King <peff@peff.net>

-Peff

  parent reply	other threads:[~2013-11-03  8:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29  2:36 [PATCH v4] remote-curl: fix large pushes with GSSAPI brian m. carlson
2013-10-30  8:45 ` Jeff King
2013-10-30 22:40   ` brian m. carlson
2013-10-31  6:34     ` Jeff King
2013-10-31  6:35       ` [PATCH 1/3] http: return curl's AUTHAVAIL via slot_results Jeff King
2013-10-31  6:36       ` [PATCH 2/3] remote-curl: pass curl slot_results back through run_slot Jeff King
2013-10-31 17:11         ` [BUG?] "error: cache entry has null sha1" Junio C Hamano
2013-10-31 17:15           ` Jeff King
2013-10-31 17:21             ` Jeff King
2013-10-31 18:07               ` Junio C Hamano
2013-11-01 22:44               ` Re* " Junio C Hamano
2013-11-01 22:44                 ` [PATCH 1/3] unpack-trees: fix "read-tree -u --reset A B" with conflicted index Junio C Hamano
2013-11-01 22:44                 ` [PATCH 2/3] t1005: reindent Junio C Hamano
2013-11-01 22:44                 ` [PATCH 3/3] t1005: add test for "read-tree --reset -u A B" Junio C Hamano
2013-11-03  8:03                 ` Jeff King [this message]
2013-10-31  6:36       ` [PATCH 3/3] remote-curl: fix large pushes with GSSAPI Jeff King
2013-10-31 22:49         ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131103080300.GA2868@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).