From: Jeff King <peff@peff.net>
To: Karsten Blees <karsten.blees@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>, Duy Nguyen <pclouds@gmail.com>
Subject: Re: [PATCH 2/2] gitignore.txt: clarify recursive nature of excluded directories
Date: Thu, 7 Nov 2013 12:57:32 -0800 [thread overview]
Message-ID: <20131107205732.GA16564@sigill.intra.peff.net> (raw)
In-Reply-To: <527BF7A4.6070203@gmail.com>
On Thu, Nov 07, 2013 at 09:27:16PM +0100, Karsten Blees wrote:
> > How about:
> >
> > It is not possible to re-include a file if a parent directory of that
> > file is excluded. Once git considers a directory excluded, it does not
> > descend into the directory to consider its contents further.
> >
>
> Hmm...an unsuspecting reader might still assume that it works in
> top-level .gitignore, given the precendence rules above...
>
> How about this:
>
> It is not possible to re-include a file if a parent directory of that
> file is excluded. Git doesn't list excluded directories for performance
> reasons, so any patterns on contained files have no effect, no matter
> where they are defined.
Yeah, I like that.
-Peff
next prev parent reply other threads:[~2013-11-07 20:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 16:30 [PATCH 0/2] Improve gitignore documentation wrt excluded directories Karsten Blees
2013-11-07 16:30 ` [PATCH 1/2] gitignore.txt: fix documentation of "**" patterns Karsten Blees
2013-11-07 18:50 ` Junio C Hamano
2013-11-07 16:31 ` [PATCH 2/2] gitignore.txt: clarify recursive nature of excluded directories Karsten Blees
2013-11-07 18:57 ` Junio C Hamano
2013-11-07 19:37 ` Junio C Hamano
2013-11-07 19:55 ` Jeff King
2013-11-07 20:27 ` Karsten Blees
2013-11-07 20:57 ` Jeff King [this message]
2013-11-07 21:36 ` Karsten Blees
2013-11-07 22:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107205732.GA16564@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karsten.blees@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).