From: Jeff King <peff@peff.net>
To: Thomas Rast <tr@thomasrast.ch>
Cc: "Johannes Sixt" <j6t@kdbg.org>,
"Torsten Bögershausen" <tboegi@web.de>,
"Ramsay Jones" <ramsay@ramsay1.demon.co.uk>,
"Vicent Marti" <tanoku@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>,
"GIT Mailing-list" <git@vger.kernel.org>
Subject: Re: [PATCH 0/5] fix up 'jk/pack-bitmap' branch
Date: Sat, 9 Nov 2013 16:21:07 -0500 [thread overview]
Message-ID: <20131109212106.GA2712@sigill.intra.peff.net> (raw)
In-Reply-To: <87txflnv7n.fsf@linux-k42r.v.cablecom.net>
On Sat, Nov 09, 2013 at 10:03:56PM +0100, Thomas Rast wrote:
> > Of course. You write little endian and also read back little endian;
> > that should work just fine, no?
> >
> > OTOH, if you write with Intel and read with PPC, then you should observe
> > misbehavior with the above patch.
>
> Maybe you could check in a simple test that the bitmap for a very
> predictable pack (e.g. only one commit) has a certain content, by
> checking its hash. That would guard against accidental format changes.
Another option would be to cross-check reading and writing against JGit,
which is valuable for other reasons besides checking endianness. I do
not think most people will have JGit installed, but it's better than
nothing (and if even one person runs it, we have a chance of finding a
bug).
-Peff
prev parent reply other threads:[~2013-11-09 21:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 21:58 [PATCH 0/5] fix up 'jk/pack-bitmap' branch Ramsay Jones
2013-11-07 22:19 ` Jeff King
2013-11-08 1:39 ` Vicent Martí
2013-11-08 17:10 ` Torsten Bögershausen
2013-11-08 18:23 ` Ramsay Jones
2013-11-08 22:29 ` Jeff King
2013-11-09 11:35 ` Torsten Bögershausen
2013-11-09 17:25 ` Johannes Sixt
2013-11-09 21:03 ` Thomas Rast
2013-11-09 21:21 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131109212106.GA2712@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=tanoku@gmail.com \
--cc=tboegi@web.de \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).