From: Christian Couder <chriscool@tuxfamily.org>
To: jrnieder@gmail.com
Cc: gitster@pobox.com, git@vger.kernel.org, apenwarr@gmail.com,
Johannes.Schindelin@gmx.de, peff@peff.net, max@quendi.de,
ae@op5.se
Subject: Re: [PATCH v4 2/2] Rename suffixcmp() to ends_with() and invert its result
Date: Tue, 19 Nov 2013 22:04:38 +0100 (CET) [thread overview]
Message-ID: <20131119.220438.1634671089949485179.chriscool@tuxfamily.org> (raw)
In-Reply-To: <20131119191322.GA4212@google.com>
From: Jonathan Nieder <jrnieder@gmail.com>
> Christian Couder wrote:
>
>> And in vcs-svn/fast_export.c there was already an ends_with()
>> function that did the same thing. Let's used the renamed one
>> while at it.
>
> Yes, despite the change in signature this shouldn't slow anything
> down. Thanks.
>
> For what it's worth,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks.
To avoid spamming the list again, I am going to send the following
patches from the 86 patch long series to replace prefixcmp() with
starts_with():
[PATCH v2 00/86] replace prefixcmp() with starts_with()
[PATCH v2 01/86] strbuf: add starts_with() to be used instead of prefixcmp()
[PATCH v2 02/86] diff: replace prefixcmp() with starts_with()
[PATCH v2 08/86] transport*: replace prefixcmp() with starts_with()
[PATCH v2 40/86] environment: replace prefixcmp() with starts_with()
[PATCH v2 86/86] strbuf: remove prefixcmp() as it has been replaced with starts_with()
If there are no problems with them, then I will suppose that most of
the patches are ok and probably send them all unless I am asked not
to.
Cheers,
Christian.
next prev parent reply other threads:[~2013-11-19 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-17 8:39 [PATCH v4 2/2] Rename suffixcmp() to ends_with() and invert its result Christian Couder
2013-11-19 19:13 ` Jonathan Nieder
2013-11-19 21:04 ` Christian Couder [this message]
2013-11-19 21:32 ` Antoine Pelisse
2013-11-19 22:28 ` Junio C Hamano
2013-11-21 7:32 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131119.220438.1634671089949485179.chriscool@tuxfamily.org \
--to=chriscool@tuxfamily.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=ae@op5.se \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=max@quendi.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).