From: Joey Hess <joey@kitenet.net>
To: git@vger.kernel.org
Subject: Re: [PATCH] drop support for "experimental" loose objects
Date: Thu, 21 Nov 2013 12:04:26 -0400 [thread overview]
Message-ID: <20131121160426.GA21843@kitenet.net> (raw)
In-Reply-To: <20131121114157.GA7171@sigill.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
Jeff King wrote:
> This latter behavior is much worse for two reasons. One,
> git reports an allocation error when the real error is
> corruption. And two, the program dies unconditionally, so
> you cannot even run fsck (which would otherwise ignore the
> broken object and keep going).
BTW, I've also seen git cat-file --batch report wrong sizes for objects,
sometimes without crashing. This is particularly problimatic because if
the object size is wrong, it's very hard to detect the actual end of the
object output in the batch mode stream.
--
see shy jo
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2013-11-21 16:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 20:33 corrupt object memory allocation error Joey Hess
2013-11-20 21:33 ` Jeff King
2013-11-20 22:28 ` Joey Hess
2013-11-21 11:41 ` [PATCH] drop support for "experimental" loose objects Jeff King
2013-11-21 11:48 ` Jeff King
2013-11-21 12:43 ` Duy Nguyen
2013-11-21 14:42 ` Keshav Kini
2013-11-21 22:41 ` Jeff King
2013-11-21 19:44 ` Junio C Hamano
2013-11-23 0:24 ` Jonathan Nieder
2013-11-23 0:30 ` Jeff King
2013-11-23 0:47 ` Jonathan Nieder
2013-11-21 16:04 ` Joey Hess [this message]
2013-11-21 20:19 ` Christian Couder
2013-11-22 9:58 ` Jeff King
2013-11-22 11:04 ` Christian Couder
2013-11-22 11:24 ` Jeff King
2013-11-22 14:23 ` Christian Couder
2013-11-22 16:15 ` Jeff King
2013-11-22 17:23 ` Junio C Hamano
2013-11-22 2:09 ` Jeff King
2013-11-22 17:28 ` Joey Hess
2013-11-24 8:44 ` Jeff King
2013-11-24 9:07 ` Jeff King
2013-11-25 18:35 ` Junio C Hamano
2013-11-27 9:30 ` Jeff King
2013-11-27 18:57 ` Junio C Hamano
2013-11-27 19:03 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131121160426.GA21843@kitenet.net \
--to=joey@kitenet.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).