git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Couder <chriscool@tuxfamily.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
	Joey Hess <joey@kitenet.net>
Subject: [PATCH v2 01/10] Rename READ_SHA1_FILE_REPLACE flag to LOOKUP_REPLACE_OBJECT
Date: Sat, 07 Dec 2013 17:20:56 +0100	[thread overview]
Message-ID: <20131207162106.21478.3934.chriscool@tuxfamily.org> (raw)
In-Reply-To: <20131207160514.21478.72966.chriscool@tuxfamily.org>

The READ_SHA1_FILE_REPLACE flag is more related to using the
lookup_replace_object() function rather than the
read_sha1_file() function.

We also need such a flag to be used with sha1_object_info()
instead of read_sha1_file().

The name LOOKUP_REPLACE_OBJECT is therefore better for this
flag.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 cache.h     | 4 ++--
 sha1_file.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/cache.h b/cache.h
index ce377e1..873a6b5 100644
--- a/cache.h
+++ b/cache.h
@@ -760,11 +760,11 @@ int daemon_avoid_alias(const char *path);
 int offset_1st_component(const char *path);
 
 /* object replacement */
-#define READ_SHA1_FILE_REPLACE 1
+#define LOOKUP_REPLACE_OBJECT 1
 extern void *read_sha1_file_extended(const unsigned char *sha1, enum object_type *type, unsigned long *size, unsigned flag);
 static inline void *read_sha1_file(const unsigned char *sha1, enum object_type *type, unsigned long *size)
 {
-	return read_sha1_file_extended(sha1, type, size, READ_SHA1_FILE_REPLACE);
+	return read_sha1_file_extended(sha1, type, size, LOOKUP_REPLACE_OBJECT);
 }
 extern const unsigned char *do_lookup_replace_object(const unsigned char *sha1);
 static inline const unsigned char *lookup_replace_object(const unsigned char *sha1)
diff --git a/sha1_file.c b/sha1_file.c
index daacc0c..76e9f32 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -2591,7 +2591,7 @@ void *read_sha1_file_extended(const unsigned char *sha1,
 	void *data;
 	char *path;
 	const struct packed_git *p;
-	const unsigned char *repl = (flag & READ_SHA1_FILE_REPLACE)
+	const unsigned char *repl = (flag & LOOKUP_REPLACE_OBJECT)
 		? lookup_replace_object(sha1) : sha1;
 
 	errno = 0;
-- 
1.8.5.1.102.g090758b

  reply	other threads:[~2013-12-07 16:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-07 16:20 [PATCH v2 00/10] teach replace objects to sha1_object_info_extended() Christian Couder
2013-12-07 16:20 ` Christian Couder [this message]
2013-12-07 16:20 ` [PATCH v2 02/10] replace_object: don't check read_replace_refs twice Christian Couder
2013-12-07 16:20 ` [PATCH v2 03/10] Introduce lookup_replace_object_extended() to pass flags Christian Couder
2013-12-07 16:20 ` [PATCH v2 04/10] Add an "unsigned flags" parameter to sha1_object_info_extended() Christian Couder
2013-12-07 16:21 ` [PATCH v2 05/10] t6050: show that git cat-file --batch fails with replace objects Christian Couder
2013-12-07 16:21 ` [PATCH v2 06/10] sha1_file: perform object replacement in sha1_object_info_extended() Christian Couder
2013-12-07 16:21 ` [PATCH v2 07/10] builtin/replace: teach listing using short, medium or full formats Christian Couder
2013-12-07 16:21 ` [PATCH v2 08/10] t6050: add tests for listing with --format Christian Couder
2013-12-09  3:19   ` Eric Sunshine
2013-12-09  5:58     ` Christian Couder
2013-12-07 16:21 ` [PATCH v2 09/10] builtin/replace: unset read_replace_refs Christian Couder
2013-12-07 19:02   ` Jakub Narebski
2013-12-07 19:37     ` Christian Couder
2013-12-07 16:21 ` [PATCH v2 10/10] Documentation/git-replace: describe --format option Christian Couder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131207162106.21478.3934.chriscool@tuxfamily.org \
    --to=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=joey@kitenet.net \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).