From: Jeff King <peff@peff.net>
To: "Dale R. Worley" <worley@alum.mit.edu>
Cc: git@vger.kernel.org
Subject: Re: "git fsck" fails on malloc of 80 G
Date: Mon, 16 Dec 2013 14:15:00 -0500 [thread overview]
Message-ID: <20131216191500.GD29324@sigill.intra.peff.net> (raw)
In-Reply-To: <201312161605.rBGG5Wm5027739@hobgoblin.ariadne.com>
On Mon, Dec 16, 2013 at 11:05:32AM -0500, Dale R. Worley wrote:
> # git fsck
> Checking object directories: 100% (256/256), done.
> fatal: Out of memory, malloc failed (tried to allocate 80530636801 bytes)
> #
Can you give you give us a backtrace from the die() call? It would help
to know what it was trying to allocate 80G for.
> I don't know if this is due to an outright bug or not. But it seems
> to me that "git fsck" should not need to allocate any more memory than
> the size (1 GiB) of a single pack file. And given its purpose, "git
> fsck" should be one of the *most* robust Git tools!
Agreed. Fsck tends to be more robust, but there are still many code
paths that can die(). One of the problems I ran into recently is that
corrupt data can cause it to make a large allocation; we notice the
bogus data as soon as we try to start filling the buffer, but sometimes
the bogus allocation is large enough to kill the process.
That was fixed by b039718, which is in master but not yet any released
version. You might see whether that helps.
-Peff
next prev parent reply other threads:[~2013-12-16 19:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 16:05 "git fsck" fails on malloc of 80 G Dale R. Worley
2013-12-16 19:15 ` Jeff King [this message]
2013-12-18 3:06 ` Dale R. Worley
2013-12-18 21:58 ` Jeff King
2013-12-18 21:08 ` Dale R. Worley
2013-12-18 22:09 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131216191500.GD29324@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=worley@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).