From: Jonathan Nieder <jrnieder@gmail.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] daemon: be strict at parsing parameters --[no-]informative-errors
Date: Fri, 20 Dec 2013 10:46:44 -0800 [thread overview]
Message-ID: <20131220184644.GA10609@google.com> (raw)
In-Reply-To: <1387536832-650-1-git-send-email-pclouds@gmail.com>
Hi,
Nguyễn Thái Ngọc Duy wrote:
> Use strcmp() instead of starts_with() to stop accepting
> --informative-errors-just-a-little
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Good catch. When this use of prefixcmp was introduced in
v1.7.8-rc0~28^2 (daemon: give friendlier error messages to clients,
2011-10-14) I think it was just a typo.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
prev parent reply other threads:[~2013-12-20 18:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 10:53 [PATCH] daemon: be strict at parsing parameters --[no-]informative-errors Nguyễn Thái Ngọc Duy
2013-12-20 18:46 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131220184644.GA10609@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).