git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: John Keeping <john@keeping.me.uk>, Thomas Rast <tr@thomasrast.ch>
Subject: [PATCH 3/3] t0000: drop "known breakage" test
Date: Sat, 28 Dec 2013 04:33:40 -0500	[thread overview]
Message-ID: <20131228093340.GC21109@sigill.intra.peff.net> (raw)
In-Reply-To: <20131228092731.GA26337@sigill.intra.peff.net>

Having a simulated "known breakage" test means that the test
suite will always tell us there is a bug to be fixed, even
though it is only simulated.

The right way to test this is in a sub-test, that can also
check that we provide the correct exit status and output.
Fortunately, we already have such a test (added much later
by 5ebf89e).

We could arguably get rid of the simulated success test
immediately above, as well, as it is also redundant with the
tests added in 5ebf89e. However, it does not have the
annoying behavior of the "known breakage" test. It may also
be easier to debug if the test suite is truly broken, since
it is not a test-within-a-test, as the later tests are.

Signed-off-by: Jeff King <peff@peff.net>
---
I am not _that_ bothered by the "known breakage", but AFAICT there is
zero benefit to keeping this redundant test. But maybe I am missing
something.

 t/t0000-basic.sh | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index e6c5b63..a2bb63c 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -41,9 +41,6 @@ test_expect_success '.git/objects should have 3 subdirectories' '
 test_expect_success 'success is reported like this' '
 	:
 '
-test_expect_failure 'pretend we have a known breakage' '
-	false
-'
 
 run_sub_test_lib_test () {
 	name="$1" descr="$2" # stdin is the body of the test code
-- 
1.8.5.1.399.g900e7cd

  parent reply	other threads:[~2013-12-28  9:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-28  9:27 [PATCH 0/3] t0000 cleanups Jeff King
2013-12-28  9:29 ` [PATCH 1/3] t0000: set TEST_OUTPUT_DIRECTORY for sub-tests Jeff King
2013-12-28 22:13   ` Jonathan Nieder
2013-12-28 22:20     ` Jonathan Nieder
2013-12-29  7:17     ` Jeff King
2013-12-28  9:31 ` [PATCH 2/3] t0000: simplify HARNESS_ACTIVE hack Jeff King
2013-12-28 22:14   ` Jonathan Nieder
2013-12-28  9:33 ` Jeff King [this message]
2013-12-28 20:51   ` [PATCH 3/3] t0000: drop "known breakage" test Jonathan Nieder
2013-12-29  7:22     ` Jeff King
2013-12-28 22:21 ` [PATCH 0/3] t0000 cleanups Jonathan Nieder
2013-12-30 18:30   ` Junio C Hamano
2013-12-30 18:51     ` Jonathan Nieder
2013-12-30 19:24       ` Junio C Hamano
2013-12-31 10:33       ` Jeff King
2014-01-02 22:28         ` Jonathan Nieder
2014-01-02 22:41           ` Junio C Hamano
2014-01-03  1:04           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131228093340.GC21109@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=john@keeping.me.uk \
    --cc=tr@thomasrast.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).