From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, John Keeping <john@keeping.me.uk>,
Thomas Rast <tr@thomasrast.ch>
Subject: Re: [PATCH 3/3] t0000: drop "known breakage" test
Date: Sat, 28 Dec 2013 12:51:04 -0800 [thread overview]
Message-ID: <20131228205104.GA5544@google.com> (raw)
In-Reply-To: <20131228093340.GC21109@sigill.intra.peff.net>
Jeff King wrote:
> I am not _that_ bothered by the "known breakage", but AFAICT there is
> zero benefit to keeping this redundant test.
Devil's advocate: it ensures that anyone wrapping git's tests (like
the old smoketest infrastructure experiment) is able to handle an
expected failure.
But in practice I don't mind the behavior before or after this patch.
If the test harness is that broken, we'll know. And people writing
code that wraps git's tests can write their own custom sanity-checks.
next prev parent reply other threads:[~2013-12-28 20:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-28 9:27 [PATCH 0/3] t0000 cleanups Jeff King
2013-12-28 9:29 ` [PATCH 1/3] t0000: set TEST_OUTPUT_DIRECTORY for sub-tests Jeff King
2013-12-28 22:13 ` Jonathan Nieder
2013-12-28 22:20 ` Jonathan Nieder
2013-12-29 7:17 ` Jeff King
2013-12-28 9:31 ` [PATCH 2/3] t0000: simplify HARNESS_ACTIVE hack Jeff King
2013-12-28 22:14 ` Jonathan Nieder
2013-12-28 9:33 ` [PATCH 3/3] t0000: drop "known breakage" test Jeff King
2013-12-28 20:51 ` Jonathan Nieder [this message]
2013-12-29 7:22 ` Jeff King
2013-12-28 22:21 ` [PATCH 0/3] t0000 cleanups Jonathan Nieder
2013-12-30 18:30 ` Junio C Hamano
2013-12-30 18:51 ` Jonathan Nieder
2013-12-30 19:24 ` Junio C Hamano
2013-12-31 10:33 ` Jeff King
2014-01-02 22:28 ` Jonathan Nieder
2014-01-02 22:41 ` Junio C Hamano
2014-01-03 1:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131228205104.GA5544@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
--cc=peff@peff.net \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).