From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, John Keeping <john@keeping.me.uk>,
Thomas Rast <tr@thomasrast.ch>
Subject: Re: [PATCH 0/3] t0000 cleanups
Date: Thu, 2 Jan 2014 20:04:44 -0500 [thread overview]
Message-ID: <20140103010444.GA13018@sigill.intra.peff.net> (raw)
In-Reply-To: <20140102222833.GR20443@google.com>
On Thu, Jan 02, 2014 at 02:28:33PM -0800, Jonathan Nieder wrote:
> > This is not exactly true. The TEST_OUTPUT_DIRECTORY setting does not
> > leak. t0000 sets $TEST_DIRECTORY (which it must, so the sub-scripts can
> > find test-lib.sh and friends), and then TEST_OUTPUT_DIRECTORY uses that
> > as a default if it is not explicitly set.
>
> So I should have said something like the following instead:
> [...]
Yes, looks good to me.
-Peff
prev parent reply other threads:[~2014-01-03 1:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-28 9:27 [PATCH 0/3] t0000 cleanups Jeff King
2013-12-28 9:29 ` [PATCH 1/3] t0000: set TEST_OUTPUT_DIRECTORY for sub-tests Jeff King
2013-12-28 22:13 ` Jonathan Nieder
2013-12-28 22:20 ` Jonathan Nieder
2013-12-29 7:17 ` Jeff King
2013-12-28 9:31 ` [PATCH 2/3] t0000: simplify HARNESS_ACTIVE hack Jeff King
2013-12-28 22:14 ` Jonathan Nieder
2013-12-28 9:33 ` [PATCH 3/3] t0000: drop "known breakage" test Jeff King
2013-12-28 20:51 ` Jonathan Nieder
2013-12-29 7:22 ` Jeff King
2013-12-28 22:21 ` [PATCH 0/3] t0000 cleanups Jonathan Nieder
2013-12-30 18:30 ` Junio C Hamano
2013-12-30 18:51 ` Jonathan Nieder
2013-12-30 19:24 ` Junio C Hamano
2013-12-31 10:33 ` Jeff King
2014-01-02 22:28 ` Jonathan Nieder
2014-01-02 22:41 ` Junio C Hamano
2014-01-03 1:04 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140103010444.GA13018@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=john@keeping.me.uk \
--cc=jrnieder@gmail.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).