From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Voigt Subject: Re: [PATCH] Documentation/gitmodules: Only 'update' and 'url' are required Date: Sat, 4 Jan 2014 23:17:54 +0100 Message-ID: <20140104221754.GB5697@book-mint> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Git , Junio C Hamano , Jens Lehmann To: "W. Trevor King" X-From: git-owner@vger.kernel.org Sat Jan 04 23:18:15 2014 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VzZXq-0007du-30 for gcvg-git-2@plane.gmane.org; Sat, 04 Jan 2014 23:18:14 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754921AbaADWSI (ORCPT ); Sat, 4 Jan 2014 17:18:08 -0500 Received: from smtprelay01.ispgateway.de ([80.67.29.23]:55993 "EHLO smtprelay01.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754352AbaADWSH (ORCPT ); Sat, 4 Jan 2014 17:18:07 -0500 Received: from [77.20.146.74] (helo=book-mint) by smtprelay01.ispgateway.de with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1VzZXb-0003eH-8u; Sat, 04 Jan 2014 23:17:59 +0100 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Df-Sender: aHZvaWd0QGh2b2lndC5uZXQ= Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Fri, Jan 03, 2014 at 10:31:22AM -0800, W. Trevor King wrote: > From: "W. Trevor King" > > Before this commit, all the settings fell under the initial "Each > submodule section also contains the following required keys:". The > example shows sections with just 'update' and 'url' entries, but we You mean: ...with just 'path' and 'url' entries... ? Other than that, the patch looks good to me. Cheers Heiko