git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [PATCH 2/2] format-patch: introduce format.defaultTo
Date: Mon, 6 Jan 2014 10:35:48 -0800	[thread overview]
Message-ID: <20140106183548.GG3881@google.com> (raw)
In-Reply-To: <1389028732-27760-3-git-send-email-artagnon@gmail.com>

Hi,

Ramkumar Ramachandra wrote:

>                      a plain
>
>   $ git format-patch -o outgoing
>
> is a no-op on a topic branch, and the user has to remember to specify
> 'master' explicitly everytime. Save the user the extra keystrokes by
> introducing format.defaultTo

Not excited.  Two reasons:

 1. Most config settings are in noun form: e.g.,
    "[remote] pushDefault = foo".  That makes their names easy to guess
    and makes them easy to talk about: I set the default remote for
    pushing by changing the remote.pushdefault setting.

    '[url "<foo>"] insteadOf' is an exception to that and a bit of an
    aberration.

    This new '[format] defaultTo' repeats the same end-with-a-preposition
    mistake, while I think it would be better to learn from it.

 2. Wouldn't a more natural default be @{u}..HEAD instead of relying on
    the user to do the make-work of keeping a local branch that tracks
    master up to date?

Hope that helps,
Jonathan

  reply	other threads:[~2014-01-06 18:35 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06 17:18 [PATCH 0/2] Minor convinience feature: format.defaultTo Ramkumar Ramachandra
2014-01-06 17:18 ` [PATCH 1/2] completion: complete format.coverLetter Ramkumar Ramachandra
2014-01-07 11:24   ` Ramkumar Ramachandra
2014-01-06 17:18 ` [PATCH 2/2] format-patch: introduce format.defaultTo Ramkumar Ramachandra
2014-01-06 18:35   ` Jonathan Nieder [this message]
2014-01-06 19:02     ` Ramkumar Ramachandra
2014-01-06 18:42   ` Junio C Hamano
2014-01-06 18:49     ` Ramkumar Ramachandra
2014-01-06 20:06       ` Junio C Hamano
2014-01-06 20:18         ` Jeff King
2014-01-06 20:29           ` John Szakmeister
2014-01-06 20:42             ` Jonathan Nieder
2014-01-06 21:13               ` John Szakmeister
2014-01-06 21:37                 ` Junio C Hamano
2014-01-06 22:54                 ` Ramkumar Ramachandra
2014-01-07  0:42                   ` John Szakmeister
2014-01-07 16:47                     ` Ramkumar Ramachandra
2014-01-06 20:43             ` Jeff King
2014-01-06 20:38           ` Junio C Hamano
2014-01-06 20:55             ` Jeff King
2014-01-06 21:21               ` Junio C Hamano
2014-01-06 22:10           ` Ramkumar Ramachandra
2014-01-07 20:56             ` Jeff King
2014-01-07 21:07               ` Junio C Hamano
2014-01-07 21:24                 ` Jeff King
2014-01-07 22:06                   ` Junio C Hamano
2014-01-07 22:17                     ` Jeff King
2014-01-07 22:27                       ` Junio C Hamano
2014-04-10 19:17             ` Felipe Contreras
2014-01-06 21:59         ` Ramkumar Ramachandra
2014-01-06 22:22           ` Junio C Hamano
2014-01-06 22:47             ` Ramkumar Ramachandra
2014-01-07 21:06               ` Jeff King
2014-01-07 21:25                 ` Ramkumar Ramachandra
2014-01-07 21:30                   ` Jeff King
2014-04-10 19:20                   ` Felipe Contreras
2014-01-06 17:25 ` [PATCH 0/2] Minor convinience feature: format.defaultTo Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140106183548.GG3881@google.com \
    --to=jrnieder@gmail.com \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).