From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] format-patch: introduce format.defaultTo
Date: Mon, 6 Jan 2014 15:18:54 -0500 [thread overview]
Message-ID: <20140106201854.GA28162@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqa9f8j2n8.fsf@gitster.dls.corp.google.com>
On Mon, Jan 06, 2014 at 12:06:51PM -0800, Junio C Hamano wrote:
> Unless you set @{u} to this new configuration, in which case the
> choice becomes dynamic depending on the current branch, but
>
> - if that is the only sane choice based on the current branch, why
> not use that as the default without having to set the
> configuration?
>
> - Or if that is still insufficient, don't we need branch.*.forkedFrom
> that is different from branch.*.merge, so that different branches
> you want to show "format-patch" output can have different
> reference points?
Yeah, I had similar thoughts. I personally use "branch.*.merge" as
"forkedFrom", and it seems like we are going that way anyway with things
like "git rebase" and "git merge" defaulting to upstream. But then there
is "git push -u" and "push.default = upstream", which treats the
upstream config as something else entirely.
So it seems like there is already some confusion, and either way we go,
thisis making it worse to some degree (I do not blame Ram, but rather he
has stumbled into a hidden sand pit that we have been building for the
past few years... :).
I wonder if it is too late to try to clarify this dual usage. It kind of
seems like the push config is "this is the place I publish to". Which,
in many workflows, just so happens to be the exact same as the place you
forked from. Could we introduce a new branch.*.pushupstream variable
that falls back to branch.*.merge? Or is that just throwing more fuel on
the fire (more sand in the pit in my analogy, I guess).
I admit I haven't thought it through yet, though. And even if it does
work, it may throw a slight monkey wrench in the proposed push.default
transition.
-Peff
next prev parent reply other threads:[~2014-01-06 20:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 17:18 [PATCH 0/2] Minor convinience feature: format.defaultTo Ramkumar Ramachandra
2014-01-06 17:18 ` [PATCH 1/2] completion: complete format.coverLetter Ramkumar Ramachandra
2014-01-07 11:24 ` Ramkumar Ramachandra
2014-01-06 17:18 ` [PATCH 2/2] format-patch: introduce format.defaultTo Ramkumar Ramachandra
2014-01-06 18:35 ` Jonathan Nieder
2014-01-06 19:02 ` Ramkumar Ramachandra
2014-01-06 18:42 ` Junio C Hamano
2014-01-06 18:49 ` Ramkumar Ramachandra
2014-01-06 20:06 ` Junio C Hamano
2014-01-06 20:18 ` Jeff King [this message]
2014-01-06 20:29 ` John Szakmeister
2014-01-06 20:42 ` Jonathan Nieder
2014-01-06 21:13 ` John Szakmeister
2014-01-06 21:37 ` Junio C Hamano
2014-01-06 22:54 ` Ramkumar Ramachandra
2014-01-07 0:42 ` John Szakmeister
2014-01-07 16:47 ` Ramkumar Ramachandra
2014-01-06 20:43 ` Jeff King
2014-01-06 20:38 ` Junio C Hamano
2014-01-06 20:55 ` Jeff King
2014-01-06 21:21 ` Junio C Hamano
2014-01-06 22:10 ` Ramkumar Ramachandra
2014-01-07 20:56 ` Jeff King
2014-01-07 21:07 ` Junio C Hamano
2014-01-07 21:24 ` Jeff King
2014-01-07 22:06 ` Junio C Hamano
2014-01-07 22:17 ` Jeff King
2014-01-07 22:27 ` Junio C Hamano
2014-04-10 19:17 ` Felipe Contreras
2014-01-06 21:59 ` Ramkumar Ramachandra
2014-01-06 22:22 ` Junio C Hamano
2014-01-06 22:47 ` Ramkumar Ramachandra
2014-01-07 21:06 ` Jeff King
2014-01-07 21:25 ` Ramkumar Ramachandra
2014-01-07 21:30 ` Jeff King
2014-04-10 19:20 ` Felipe Contreras
2014-01-06 17:25 ` [PATCH 0/2] Minor convinience feature: format.defaultTo Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106201854.GA28162@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).