From: Jeff King <peff@peff.net>
To: Ben Maurer <bmaurer@fb.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH] [RFC] Making use of bitmaps for thin objects
Date: Mon, 6 Jan 2014 16:57:13 -0500 [thread overview]
Message-ID: <20140106215713.GA7133@sigill.intra.peff.net> (raw)
In-Reply-To: <5CDDBDF2D36D9F43B9F5E99003F6A0D4466883DF@PRN-MBX02-1.TheFacebook.com>
On Mon, Jan 06, 2014 at 09:15:04PM +0000, Ben Maurer wrote:
> > Let me know how this patch does for you. My testing has been fairly
> > limited so far.
>
> This patch looks like a much cleaner version :-). Works well for me,
> but my test setup may not be great since I didn't get any errors from
> completely ignoring the haves bitmap :-).
Great. Out of curiosity, can you show the before/after? The timings
should be similar to what your patch produced, but I'm really curious to
see how the pack size changes.
-Peff
next prev parent reply other threads:[~2014-01-06 21:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-22 19:47 [PATCH] [RFC] Making use of bitmaps for thin objects Ben Maurer
2013-12-22 21:55 ` Ben Maurer
2014-01-06 15:10 ` Jeff King
2014-01-06 16:37 ` Junio C Hamano
2014-01-06 19:41 ` Jeff King
2014-01-06 14:57 ` Jeff King
2014-01-06 20:38 ` Jeff King
2014-01-06 21:15 ` Ben Maurer
2014-01-06 21:57 ` Jeff King [this message]
2014-01-06 22:14 ` Ben Maurer
2014-01-07 17:26 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140106215713.GA7133@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bmaurer@fb.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).