From: Pete Wyckoff <pw@padd.com>
To: Maxime Coste <frrrwww@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-p4: Do not include diff in spec file when just preparing p4
Date: Sun, 12 Jan 2014 17:29:46 -0500 [thread overview]
Message-ID: <20140112222946.GA13519@padd.com> (raw)
In-Reply-To: <20140110181807.GA29164@nekage>
frrrwww@gmail.com wrote on Fri, 10 Jan 2014 18:18 +0000:
> The diff information render the spec file unusable as is by p4,
> do not include it when run with --prepare-p4-only so that the
> given file can be directly passed to p4.
Thanks for the patch, but I'm curious how you'd like this to
work. I never use the option myself.
As it is, --prepare-p4-only generates a file in /tmp/ that has
exactly the contents you'd see in the editor during "git p4
submit". It includes the diff of the change, presumably to help
with writing the description.
Now you can't actually feed this file directly to "p4 submit"
without deleting the diff. That's the part you don't like?
-- Pete
next prev parent reply other threads:[~2014-01-12 22:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 18:18 [PATCH] git-p4: Do not include diff in spec file when just preparing p4 Maxime Coste
2014-01-12 22:29 ` Pete Wyckoff [this message]
2014-01-13 12:10 ` Maxime Coste
2014-01-14 0:06 ` Pete Wyckoff
2014-05-24 1:39 ` Maxime Coste
2014-05-24 1:44 ` Maxime Coste
2014-05-24 13:52 ` Pete Wyckoff
2014-05-24 17:40 ` Maxime Coste
2014-06-10 12:14 ` [PATCH] Fix git-p4 submit in non --prepare-p4-only mode Maxime Coste
2014-06-10 22:39 ` Pete Wyckoff
2014-06-11 13:06 ` Maxime Coste
2014-06-11 13:36 ` Pete Wyckoff
2014-06-11 13:09 ` Maxime Coste
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140112222946.GA13519@padd.com \
--to=pw@padd.com \
--cc=frrrwww@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).