From: Jonathan Nieder <jrnieder@gmail.com>
To: "Benoît Bourbié" <benoit.bourbie@gmail.com>
Cc: git@vger.kernel.org, Max Kirillov <max@max630.net>,
Pat Thoyts <patthoyts@users.sourceforge.net>
Subject: Re: git gui crashes ( v 1.8.5.2)
Date: Mon, 13 Jan 2014 17:11:41 -0800 [thread overview]
Message-ID: <20140114011141.GF18964@google.com> (raw)
In-Reply-To: <CANJSc_uYm7f4LoZoMoVzcsmGrYnUy+2nXFL_cNWqQnwLb5J6mw@mail.gmail.com>
(just cc-ing some area experts)
Hi Benoît,
Benoît Bourbié wrote:
> git gui crashes on my Linux machin since I updated it to 1.8.5.2.
I assume you mean "master" and not 1.8.5.2, since v1.8.5.2 doesn't
include the change 918dbf58 (git-gui: right half window is paned,
2013-08-21).
> I had the message
> Error in startup script: unknown option "-stretch"
> while executing
> ".vpane.lower paneconfigure .vpane.lower.diff -stretch always"
> invoked from within
> "if {$use_ttk} {
> .vpane.lower pane .vpane.lower.diff -weight 1
> .vpane.lower pane .vpane.lower.commarea -weight 0
> } else {
> .vpane.lower paneconfigure..."
> (file "git/libexec/git-core/git-gui" line 3233)
>
> So, I reverted the change that has been made in git-gui/git-gui.sh
> (Diff and Commit Area)
>
> I replaced
>
> ${NS}::panedwindow .vpane.lower -orient vertical
> ${NS}::frame .vpane.lower.commarea
> ${NS}::frame .vpane.lower.diff -relief sunken -borderwidth 1 -height 500
> .vpane.lower add .vpane.lower.diff
> .vpane.lower add .vpane.lower.commarea
> .vpane add .vpane.lower
>
> by
>
> ${NS}::frame .vpane.lower -height 300 -width 400
> ${NS}::frame .vpane.lower.commarea
> ${NS}::frame .vpane.lower.diff -relief sunken -borderwidth 1
> pack .vpane.lower.diff -fill both -expand 1
> pack .vpane.lower.commarea -side bottom -fill x
> .vpane add .vpane.lower
> if {!$use_ttk} {.vpane paneconfigure .vpane.lower -sticky nsew}
>
> and now, git gui works as expected.
Thanks,
Jonathan
next prev parent reply other threads:[~2014-01-14 1:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-14 0:14 git gui crashes ( v 1.8.5.2) Benoît Bourbié
2014-01-14 1:11 ` Jonathan Nieder [this message]
2014-01-14 4:06 ` Benoît Bourbié
2014-01-14 6:50 ` Max Kirillov
2014-01-14 23:58 ` [PATCH] git-gui: fallback right pane to packed widgets with Tk 8.4 Max Kirillov
2014-01-16 16:39 ` Benoît Bourbié
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140114011141.GF18964@google.com \
--to=jrnieder@gmail.com \
--cc=benoit.bourbie@gmail.com \
--cc=git@vger.kernel.org \
--cc=max@max630.net \
--cc=patthoyts@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).