From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ruben Kerkhof <ruben@rubenkerkhof.com>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Igor Gnatenko <i.gnatenko.brain@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] send-email: If the ca path is not specified, use the defaults
Date: Wed, 15 Jan 2014 13:50:24 -0800 [thread overview]
Message-ID: <20140115215024.GM18964@google.com> (raw)
In-Reply-To: <xmqqob3d0w7g.fsf@gitster.dls.corp.google.com>
Junio C Hamano wrote:
> Ruben Kerkhof <ruben@rubenkerkhof.com> writes:
>> As a last check, I set smtpsslcertpath = /etc/pki/tls/cert.pem in
>> ~/.gitconfig and git-send-email works fine now.
>
> Which would mean that the existing code, by blindly defaulting to
> /etc/ssl/certs/ and misdiagnosing that the directory is meant to be
> used as SSL_ca_path, breaks a set-up that otherwise _should_ work.
[...]
> Ram (who did 35035bbf), with the patch from Ruben in the thread, do
> you get either the warning or SSL failure? Conceptually, the
> resulting code is much better, I think, without blindly defaulting
> /etc/ssl/certs and instead of relying on the underlying platform
> just working out of the box with its own default,
FWIW this should help on Mac OS X, too. Folks using git on mac
at $DAYJOB have been using the workaround described at
http://mercurial.selenic.com/wiki/CACertificates#Mac_OS_X_10.6_and_higher
so I forgot to report it. :/
Thanks,
Jonathan
next prev parent reply other threads:[~2014-01-15 21:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 17:31 [PATCH] send-email: If the ca path is not specified, use the defaults Igor Gnatenko
2014-01-15 19:26 ` Junio C Hamano
[not found] ` <7AD1C6ED-6177-415D-B342-D1FEA9F810B4@rubenkerkhof.com>
2014-01-15 21:30 ` Junio C Hamano
2014-01-15 21:50 ` Ruben Kerkhof
2014-01-15 21:50 ` Jonathan Nieder [this message]
2014-01-16 23:19 ` Junio C Hamano
2014-01-17 4:21 ` Kyle J. McKay
2014-01-17 18:14 ` Junio C Hamano
2014-01-17 23:34 ` Kyle J. McKay
2014-01-26 17:17 ` Ramkumar Ramachandra
2014-01-27 16:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140115215024.GM18964@google.com \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=i.gnatenko.brain@gmail.com \
--cc=ruben@rubenkerkhof.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).