From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH v2 1/2] revision: mark contents of an uninteresting tree uninteresting
Date: Wed, 15 Jan 2014 16:16:07 -0800 [thread overview]
Message-ID: <20140116001607.GN18964@google.com> (raw)
In-Reply-To: <1389830384-22851-2-git-send-email-gitster@pobox.com>
Junio C Hamano wrote:
> we see the top-level tree marked as uninteresting (i.e. ^A^{tree} in
> the above example) and call mark_tree_uninteresting() on it; this
> unfortunately prevents us from recursing into the tree and marking
> the objects in the tree as uninteresting.
So the tree is marked uninteresting twice --- once by setting in the
UNINTERESTING flag in handle_revision_arg() and a second attempted
time in mark_tree_uninteresting()? Makes sense.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
next prev parent reply other threads:[~2014-01-16 0:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 23:59 [PATCH v2 0/2] Propagating flags carefully from the command line Junio C Hamano
2014-01-15 23:59 ` [PATCH v2 1/2] revision: mark contents of an uninteresting tree uninteresting Junio C Hamano
2014-01-16 0:16 ` Jonathan Nieder [this message]
2014-01-16 0:35 ` Junio C Hamano
2014-01-15 23:59 ` [PATCH v2 2/2] revision: propagate flag bits from tags to pointees Junio C Hamano
2014-01-21 5:27 ` [PATCH v2 0/2] Propagating flags carefully from the command line Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140116001607.GN18964@google.com \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).