From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Yuri <yuri@rawbw.com>, git@vger.kernel.org
Subject: Re: git quietly fails on https:// URL, https errors are never reported to user
Date: Fri, 17 Jan 2014 15:18:58 -0500 [thread overview]
Message-ID: <20140117201858.GA3362@sigill.intra.peff.net> (raw)
In-Reply-To: <20140117201325.GB775@sigill.intra.peff.net>
On Fri, Jan 17, 2014 at 03:13:25PM -0500, Jeff King wrote:
> On Fri, Jan 17, 2014 at 11:43:35AM -0800, Junio C Hamano wrote:
>
> > Yuri <yuri@rawbw.com> writes:
> >
> > > I think that in a rare case of error this extra-printout wouldn't
> > > hurt.
> >
> > If the "error is rare, extra verbiage does not hurt" were a valid
> > attitude, "error is rare, non-zero exit is enough" would be equally
> > valid ;-)
>
> I think the problem is that error is _not_ rare. For years, we did not
> print the extra verbiage, and nobody complained. Then, within days of us
> making a release that included the extra line, somebody complained[1].
Forgot my footnote here, but it was:
http://article.gmane.org/gmane.comp.version-control.git/228498
which led to 266f1fd (transport-helper: be quiet on read errors from
helpers, 2013-06-21).
-Peff
next prev parent reply other threads:[~2014-01-17 20:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 12:27 git quietly fails on https:// URL, https errors are never reported to user Yuri
2014-01-16 18:03 ` Jeff King
2014-01-16 19:28 ` Yuri
2014-01-17 9:40 ` Yuri
2014-01-17 19:43 ` Junio C Hamano
2014-01-17 20:13 ` Jeff King
2014-01-17 20:18 ` Jeff King [this message]
2014-01-17 20:39 ` Yuri
2014-01-17 21:10 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140117201858.GA3362@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=yuri@rawbw.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).