git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Strainu <strainu10@gmail.com>
Cc: git@vger.kernel.org, openstack-infra@lists.openstack.org
Subject: Re: BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed
Date: Fri, 17 Jan 2014 12:41:32 -0800	[thread overview]
Message-ID: <20140117204132.GB18964@google.com> (raw)
In-Reply-To: <CAC9meRKiR+60YaGiuCu4twEt6dyWksEjHSH8YPTEvmD=LoB=aw@mail.gmail.com>

Hi,

Strainu wrote:

> strainu@emily:~/core> git review -f
> Creating a git remote called "gerrit" that maps to:
>         ssh://strainu@gerrit.wikimedia.org:29418/pywikibot/core.git
> Your change was committed before the commit hook was installed.
> Amending the commit to add a gerrit change id.
>
> At this point I ended the transaction, as I was confused by the last
> message: I was afraid the ChangeId would have changed, causing the
> patch to be attached to another review.
>
> I think git should not show this message if the change description
> already has a change id

This message doesn't come from git.  It comes from the git-review
tool (in git_review/cmd.py), so cc-ing the authors in case they
have thoughts on that.

Thanks,
Jonathan

  reply	other threads:[~2014-01-17 20:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-17 20:23 BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed Strainu
2014-01-17 20:41 ` Jonathan Nieder [this message]
2014-01-17 21:10   ` Strainu
     [not found]     ` <CAC9meR+78_EvoqHNcuPyDKOZDjSsUngziGDa2aV1QDtOb8eOXw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-01-17 23:24       ` Jerry Xinyu Zhao
2014-01-17 23:38         ` [OpenStack-Infra] " Strainu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140117204132.GB18964@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=openstack-infra@lists.openstack.org \
    --cc=strainu10@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).